From 45a0ab92dc9c07ea0382faf5bb9af32fe2649bd8 Mon Sep 17 00:00:00 2001 From: Petra Jaros Date: Wed, 3 May 2023 11:40:45 -0400 Subject: [PATCH] runtests-watch: Don't try to listen for SIGKILL It's not possible (because a SIGKILL ends the process immediately, before the process can do anything to respond to it), and in current versions of Node attempting to will throw `Error: uv_signal_start EINVAL`. Thus, removing this "listener" removes no actual functionality; it only stops the task from immediately erroring on newer versions of Node. See also: https://stackoverflow.com/questions/16311347/node-script-throws-uv-signal-start-einval --- Herebyfile.mjs | 1 - 1 file changed, 1 deletion(-) diff --git a/Herebyfile.mjs b/Herebyfile.mjs index 9c58b68681b87..883ba191f18d2 100644 --- a/Herebyfile.mjs +++ b/Herebyfile.mjs @@ -616,7 +616,6 @@ export const runTestsAndWatch = task({ }); process.on("SIGINT", endWatchMode); - process.on("SIGKILL", endWatchMode); process.on("beforeExit", endWatchMode); watchTestsEmitter.on("rebuild", onRebuild); testCaseWatcher.on("all", onChange);