chore: Everybody gets a package (#2218)

Author: ecraig12345

.eslintrc.json

@@ -1,4 +1,4 @@
 {
-  "extends": ["./packages/internal-tooling/eslint/index.js"],
+  "extends": ["./build/eslint/index.js"],
   "root": true
 }

build/.eslintrc.json

@@ -1,5 +1,5 @@
 {
-  "extends": ["../packages/internal-tooling/eslint/index.js"],
+  "extends": ["./eslint/index.js"],
   "rules": {
     "no-console": "off"
   },

packages/internal-tooling/babel/index.js renamed to build/babel/index.js

@@ -19,7 +19,7 @@ const envConfig = {
   // ----------------------------------
   // Project Structure
   // ----------------------------------
-  path_base: __dirname,
+  path_base: path.resolve(__dirname, '..'),
   dir_build: 'build',
   dir_docs_dist: 'docs/dist',
   dir_docs_src: 'docs/src',
@@ -68,7 +68,7 @@ const paths = {
   ),
 }
 
-const isRoot = process.cwd() === __dirname
+const isRoot = process.cwd() === envConfig.path_base
 let packageName = isRoot ? 'react' : path.basename(process.cwd())
 // don't use yargs here because it causes build errors in certain circumstances
 const packageArgIndex = process.argv.indexOf('--package')

packages/internal-tooling/babel/register.js renamed to build/babel/register.js

@@ -1,6 +1,6 @@
 import * as fs from 'fs'
 
-import config from '../../config'
+import config from '../config'
 import { DangerJS } from './types'
 
 const CHANGELOG_FILE = 'CHANGELOG.md'

config.ts renamed to build/config.ts

@@ -3,7 +3,7 @@ import * as fs from 'fs-extra'
 import * as path from 'path'
 
 import { DangerJS } from './types'
-import config from '../../config'
+import config from '../config'
 
 function linkToFlamegraph(value, filename) {
   // This as well as the whole flamegrill URL is hardcoded to only work with CircleCI.

build/dangerjs/checkChangelog.ts

@@ -5,7 +5,7 @@ import {
   getPackageName,
   FailedConstraintsExplanation,
 } from './utils'
-import config from '../../../config'
+import config from '../../config'
 import { DangerJS } from '../types'
 
 const { paths } = config

build/dangerjs/checkPerfRegressions.ts

@@ -1,6 +1,6 @@
 import { spawnSync } from 'child_process'
 
-import config from '../../../../config'
+import config from '../../../config'
 
 const { paths } = config
 

build/dangerjs/detectNonApprovedDependencies/index.ts

@@ -5,7 +5,7 @@ import path from 'path'
 import through2 from 'through2'
 import Vinyl from 'vinyl'
 
-import config from '../../../config'
+import config from '../../config'
 import getComponentInfo from './util/getComponentInfo'
 
 const pluginName = 'gulp-component-menu'

build/dangerjs/detectNonApprovedDependencies/utils/getRuntimeDependencies.ts

@@ -1,7 +1,7 @@
 import fs from 'fs'
 import through2 from 'through2'
 
-import config from '../../../config'
+import config from '../../config'
 import sh from '../sh'
 
 const insideGitRepo = fs.existsSync(config.paths.base('.git'))

packages/internal-tooling/eslint/index.js renamed to build/eslint/index.js

@@ -1,8 +1,8 @@
 import webpack from 'webpack'
-import config from '../../../config'
+import config from '../../config'
+import { log, PluginError } from 'gulp-util'
 
 const { __DEV__, __SKIP_ERRORS__ } = config.compiler_globals
-const { log, PluginError } = require('gulp-load-plugins')().util
 
 const DEV_SKIP_ERRORS = __DEV__ && __SKIP_ERRORS__
 

build/gulp/plugins/gulp-component-menu.ts

@@ -1,5 +1,5 @@
 import path from 'path'
-import config from '../../../../config'
+import config from '../../../config'
 
 const examplesPath = config.paths.docsSrc('examples', 'components')
 

build/gulp/plugins/gulp-doctoc.ts

@@ -2,13 +2,10 @@ import express from 'express'
 
 import historyApiFallback from 'connect-history-api-fallback'
 import { Server } from 'http'
+import { colors, log } from 'gulp-util'
 
 type Express = ReturnType<typeof express>
 
-const g = require('gulp-load-plugins')()
-
-const { colors, log } = g.util
-
 const serve = (
   directoryPath: string,
   host: string,

build/gulp/plugins/gulp-webpack.ts

@@ -1,11 +1,11 @@
 import * as childProcess from 'child_process'
 
-const sh = (command: string, pipeOutputToResult: boolean = false): Promise<string> =>
+const sh = (command: string, cwd?: string, pipeOutputToResult: boolean = false): Promise<string> =>
   new Promise((resolve, reject) => {
     const [cmd, ...args] = command.split(' ')
 
     const options: childProcess.SpawnOptions = {
-      cwd: process.cwd(),
+      cwd: cwd || process.cwd(),
       env: process.env,
       stdio: pipeOutputToResult ? 'pipe' : [0, 1, 2],
       shell: true,

build/gulp/plugins/util/getRelativePathToSourceFile.ts

@@ -1,15 +1,13 @@
 import { task, series, parallel, src, dest } from 'gulp'
 import babel from 'gulp-babel'
+import { log, PluginError } from 'gulp-util'
 import del from 'del'
 import webpack from 'webpack'
 
-import config from '../../../config'
+import config from '../../config'
 import sh from '../sh'
 
-const g = require('gulp-load-plugins')()
-
 const { paths } = config
-const { log, PluginError } = g.util
 
 const packageName = config.package
 
@@ -47,11 +45,7 @@ task('bundle:package:es', () =>
 )
 
 task('bundle:package:types:tsc', () => {
-  let cmd = 'tsc -b'
-  if (process.cwd() === config.path_base) {
-    cmd = `cd packages && cd ${packageName} && ${cmd}`
-  }
-  return sh(cmd)
+  return sh('tsc -b', paths.packages(packageName))
 })
 task('bundle:package:types:copy', () => {
   return src(paths.packageDist(packageName, 'dts/src/**/*.d.ts')).pipe(

build/gulp/serve.ts

@@ -2,6 +2,7 @@ import { dest, lastRun, parallel, series, src, task, watch } from 'gulp'
 import chalk from 'chalk'
 import cache from 'gulp-cache'
 import remember from 'gulp-remember'
+import { log } from 'gulp-util'
 import fs from 'fs'
 import path from 'path'
 import del from 'del'
@@ -11,7 +12,7 @@ import WebpackDevMiddleware from 'webpack-dev-middleware'
 import WebpackHotMiddleware from 'webpack-hot-middleware'
 
 import sh from '../sh'
-import config from '../../../config'
+import config from '../../config'
 import gulpComponentMenu from '../plugins/gulp-component-menu'
 import gulpComponentMenuBehaviors from '../plugins/gulp-component-menu-behaviors'
 import gulpDoctoc from '../plugins/gulp-doctoc'
@@ -24,9 +25,6 @@ import { Server } from 'http'
 import serve, { forceClose } from '../serve'
 
 const { paths } = config
-const g = require('gulp-load-plugins')()
-
-const { log } = g.util
 
 const logWatchAdd = (filePath: string) => log('Created', chalk.blue(path.basename(filePath)))
 const logWatchChange = (filePath: string) => log('Changed', chalk.magenta(path.basename(filePath)))
@@ -139,7 +137,7 @@ task('build:docs:toc', () =>
 task('build:docs:schema', () =>
   src(schemaSrc, { since: lastRun('build:docs:schema') }).pipe(
     through2.obj((file, enc, done) => {
-      sh(`cd packages/ability-attributes && npm run schema`)
+      sh('npm run schema', paths.packages('ability-attributes'))
         .then(() => done(null, file))
         .catch(done)
     }),

build/gulp/sh.ts

@@ -1,6 +1,7 @@
 import express from 'express'
 import fs from 'fs'
 import { series, task } from 'gulp'
+import { colors, log } from 'gulp-util'
 import _ from 'lodash'
 import ProgressBar from 'progress'
 import puppeteer from 'puppeteer'
@@ -15,12 +16,11 @@ import {
   ProfilerMeasureCycle,
   ReducedMeasures,
 } from '../../../perf/types'
-import config from '../../../config'
+import config from '../../config'
 import webpackPlugin from '../plugins/gulp-webpack'
 import { safeLaunchOptions } from 'build/puppeteer.config'
 
 const { paths } = config
-const { colors, log } = require('gulp-load-plugins')().util
 
 const DEFAULT_RUN_TIMES = 10
 let server
@@ -109,7 +109,7 @@ const createMarkdownTable = (perExamplePerfMeasures: PerExamplePerfMeasures) =>
 task('perf:clean', () => del(paths.perfDist()))
 
 task('perf:build', cb => {
-  webpackPlugin(require('../../../build/webpack.config.perf').default, cb)
+  webpackPlugin(require('../../webpack.config.perf').default, cb)
 })
 
 task('perf:run', async () => {

build/gulp/tasks/bundle.ts

@@ -2,7 +2,7 @@ import { task, series } from 'gulp'
 import { argv } from 'yargs'
 
 import sh from '../sh'
-import config from '../../../config'
+import config from '../../config'
 
 const { paths } = config
 

build/gulp/tasks/docs.ts

@@ -1,17 +1,15 @@
 import fs from 'fs'
 import { task, parallel, series } from 'gulp'
+import { log, PluginError } from 'gulp-util'
 import _ from 'lodash'
 import webpack from 'webpack'
 import stableStringify from 'json-stable-stringify-without-jsonify'
 import { argv } from 'yargs'
 import requestHttp from 'request-promise-native'
 
-import config from '../../../config'
-
-const g = require('gulp-load-plugins')()
+import config from '../../config'
 
 const { paths } = config
-const { log, PluginError } = g.util
 
 const UNRELEASED_VERSION_STRING = 'Unreleased'
 const SEMVER_MATCHER = /(\d+)\.(\d+)\.(\d+)/

build/gulp/tasks/perf.ts

@@ -1,4 +1,4 @@
-import config from '../../../../config'
+import config from '../../../config'
 
 const reactPackageDist = (filePath: string) => config.paths.packageDist('react', 'es', filePath)
 

build/gulp/tasks/screener.ts

@@ -3,7 +3,7 @@ import fs from 'fs'
 import { task, series } from 'gulp'
 import webpackPlugin from '../../plugins/gulp-webpack'
 
-import config from '../../../../config'
+import config from '../../../config'
 
 import { cyclesToSkip } from './config'
 import { buildWebpackConfig, configureCircularDependencyCheckPlugin, isCycleToSkip } from './utils'

build/gulp/tasks/stats.ts

@@ -1,7 +1,7 @@
 import path from 'path'
 import CircularDependencyPlugin from 'circular-dependency-plugin'
 
-import config from '../../../../config'
+import config from '../../../config'
 
 export const isCycleToSkip = (proposedCycle, benignCycles) => {
   return benignCycles.some(benignCycle => {

build/gulp/tasks/test-circulars/config.ts

@@ -4,7 +4,7 @@ import * as fs from 'fs'
 import { argv } from 'yargs'
 
 import { prepareWebpackConfig, runWebpack } from './utils'
-import config from '../../../../config'
+import config from '../../../config'
 
 const { paths } = config
 

build/gulp/tasks/test-circulars/index.ts

@@ -3,7 +3,7 @@ import { webpack as lernaAliases } from 'lerna-alias'
 import { LicenseWebpackPlugin } from 'license-webpack-plugin'
 import webpack from 'webpack'
 
-import config from '../../../../config'
+import config from '../../../config'
 
 const { paths } = config
 

build/gulp/tasks/test-circulars/utils.ts

@@ -1,7 +1,7 @@
 import { task, series } from 'gulp'
 import * as yargs from 'yargs'
 import del from 'del'
-import config from '../../../config'
+import config from '../../config'
 import webpackPlugin from '../plugins/gulp-webpack'
 
 import jest from '../plugins/gulp-jest'
@@ -18,7 +18,7 @@ const argv = yargs
 task('test:e2e:clean', () => del(paths.e2eDist()))
 
 task('test:e2e:build', cb => {
-  webpackPlugin(require('../../../build/webpack.config.e2e').default, cb)
+  webpackPlugin(require('../../webpack.config.e2e').default, cb)
 })
 
 let server: Server

build/gulp/tasks/test-dependencies/index.ts

@@ -8,7 +8,7 @@ import puppeteer from 'puppeteer'
 import sh from '../sh'
 import del from 'del'
 
-import config from '../../../config'
+import config from '../../config'
 import tmp from 'tmp'
 import http from 'http'
 import { safeLaunchOptions } from 'build/puppeteer.config'
@@ -24,7 +24,7 @@ const log = (context: string) => (message: string) => {
   console.log('='.repeat(80))
 }
 
-export const runIn = targetPath => cmd => sh(`cd ${targetPath} && ${cmd}`)
+export const runIn = targetPath => cmd => sh(cmd, targetPath)
 
 const addResolutionPathsForProjectPackages = async (
   testProjectDir: string,
@@ -47,11 +47,14 @@ const packProjectPackages = async (logger: Function): Promise<PackedPackages> =>
   const projectPackages = lernaAliases({ sourceDirectory: false })
 
   // We don't want to pack a package with our dev tools
+  delete projectPackages['@fluentui/digest']
+  delete projectPackages['@fluentui/docs']
+  delete projectPackages['@fluentui/e2e']
   delete projectPackages['@fluentui/eslint-plugin']
   delete projectPackages['@fluentui/internal-tooling']
-  delete projectPackages['@fluentui/scripts']
-  delete projectPackages['@fluentui/digest']
+  delete projectPackages['@fluentui/perf']
   delete projectPackages['@fluentui/perf-test']
+  delete projectPackages['@fluentui/scripts']
 
   await Promise.all(
     Object.keys(projectPackages).map(async (packageName: string) => {

build/gulp/tasks/test-dependencies/utils.ts

@@ -3,7 +3,7 @@ import yargs from 'yargs'
 
 import jest, { JestPluginConfig } from '../plugins/gulp-jest'
 
-import config from '../../../config'
+import config from '../../config'
 
 const argv = yargs
   .option('runInBand', {})