Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Align Menu and Divider components to use the type property values as boolean #421

Closed
alinais opened this issue Nov 2, 2018 · 3 comments
Closed
Assignees
Labels
⚙️ enhancement New feature or request vsts Paired with ticket in vsts

Comments

@alinais
Copy link
Contributor

alinais commented Nov 2, 2018

Feature Request

Problem description

Align Menu and Divider components to use the type property values as boolean.

Proposed solution

Check the Button update, where primary and secondary become boolean props while the type remains as a reserved prop.

@layershifter
Copy link
Member

We have already PR for Divider: #327

@pkumarie2011 pkumarie2011 added the vsts Paired with ticket in vsts label Nov 4, 2018
@layershifter
Copy link
Member

Picking this.

@levithomason
Copy link
Member

#327 was closed since primary/secondary doesn't make sense in the context of a Divider. Instead, they will have colors. See #451 for the color palette and divider color work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚙️ enhancement New feature or request vsts Paired with ticket in vsts
Projects
None yet
Development

No branches or pull requests

4 participants