Fails to compile on ARM Linux

[stronnag]

On Arch Linux, ARM 32 bit:

 $ cmake ../../
-- The C compiler identification is GNU 8.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- No build type selected, default to *** Release ***
-- Override standard malloc (OVERRIDE=ON)
-- Output library name   : mimalloc
-- Installation directory: lib/mimalloc-1.0
-- Configuring done
-- Generating done
-- Build files have been written to: /home/jrh/Projects/mimalloc/out/release
$ make
Scanning dependencies of target mimalloc-static
[  4%] Building C object CMakeFiles/mimalloc-static.dir/src/stats.c.o
In file included from /home/jrh/Projects/mimalloc/src/stats.c:8:
/home/jrh/Projects/mimalloc/include/mimalloc-internal.h: In function ‘_mi_thread_id’:
/home/jrh/Projects/mimalloc/include/mimalloc-internal.h:312:22: error: ‘_mi_backing_heap’ undeclared (first use in this function); did you mean ‘_mi_bin_size’?
   return (uintptr_t)&_mi_backing_heap;
                      ^~~~~~~~~~~~~~~~
                      _mi_bin_size
/home/jrh/Projects/mimalloc/include/mimalloc-internal.h:312:22: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [CMakeFiles/mimalloc-static.dir/build.make:63: CMakeFiles/mimalloc-static.dir/src/stats.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:73: CMakeFiles/mimalloc-static.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

[daanx]

Ah, never tried building on ARM yet. I just pushed a possible fix to master -- can you try that?

Beyond that, the code at:
https://github.com/microsoft/mimalloc/blob/master/include/mimalloc-internal.h#L288

uses special casing to efficiently get a thread unique id. I am sure ARM will have this too and it we should add such case (for best performance).

[stronnag]

Thanks for the amazingly fast reply; the compile error moves on:

Scanning dependencies of target mimalloc-static
[  4%] Building C object CMakeFiles/mimalloc-static.dir/src/stats.c.o
In file included from /home/jrh/Projects/mimalloc/src/stats.c:8:
/home/jrh/Projects/mimalloc/include/mimalloc-internal.h: In function ‘mi_get_default_heap’:
/home/jrh/Projects/mimalloc/include/mimalloc-internal.h:156:10: error: ‘_mi_’ undeclared (first use in this function); did you mean ‘_mi_bsr’?
   return _mi_
          ^~~~
          _mi_bsr
/home/jrh/Projects/mimalloc/include/mimalloc-internal.h:156:10: note: each undeclared identifier is reported only once for each function it appears in
/home/jrh/Projects/mimalloc/include/mimalloc-internal.h:156:14: error: expected ‘;’ before ‘ault’
   return _mi_
              ^
              ;
   ault;
   ~~~~        
make[2]: *** [CMakeFiles/mimalloc-static.dir/build.make:63: CMakeFiles/mimalloc-static.dir/src/stats.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:73: 

[daanx]

Argh, accidental mistake in the fix. Can you try again?
(and from now I will switch to the dev branch for quick fixes :-) )

[stronnag]

Building (and running) --- thanks.

[daanx]

Good to hear! -- I'll look into doing efficient thread id detection on ARM (any pointers are appreciated).