Skip to content

Commit ee3ec03

Browse files
RickWinterDino
authored and
Dino
committed
BuildRelease.ps1 Fixes
Remove an extra .0 in the reference Copy the signed binaries into binaries\ and not into binaries\SignedBinaries
1 parent db3db19 commit ee3ec03

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

Common/Tests/Utilities.UI/TestUtilities.UI.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,15 @@
4949
<Reference Include="Microsoft.VisualStudio.QualityTools.UnitTestFramework, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL" />
5050
<Reference Include="Microsoft.VisualStudio.Shell.$(VSTarget), Version=$(VSTarget).0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL" />
5151
<Reference Include="Microsoft.VisualStudio.Shell.Interop, Version=7.1.40304.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" />
52-
<Reference Include="Microsoft.VisualStudio.Shell.Interop.$(VSTarget).0, Version=$(VSTarget).0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
52+
<Reference Include="Microsoft.VisualStudio.Shell.Interop.$(VSTarget), Version=$(VSTarget).0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
5353
<EmbedInteropTypes>True</EmbedInteropTypes>
5454
</Reference>
5555
<Reference Include="Microsoft.VisualStudio.Text.Data, Version=$(VSTarget).0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL" />
5656
<Reference Include="Microsoft.VisualStudio.Text.Logic, Version=$(VSTarget).0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL" />
5757
<Reference Include="Microsoft.VisualStudio.Text.UI, Version=$(VSTarget).0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL" />
5858
<Reference Include="Microsoft.VisualStudio.Text.UI.Wpf, Version=$(VSTarget).0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL" />
5959
<Reference Include="Microsoft.VisualStudio.TextManager.Interop, Version=7.1.40304.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" />
60-
<Reference Include="Microsoft.VisualStudio.TextManager.Interop.$(VSTarget).0, Version=$(VSTarget).0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
60+
<Reference Include="Microsoft.VisualStudio.TextManager.Interop.$(VSTarget), Version=$(VSTarget).0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
6161
<EmbedInteropTypes>True</EmbedInteropTypes>
6262
</Reference>
6363
<Reference Include="PresentationCore" />

Nodejs/Setup/BuildRelease.ps1

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -380,11 +380,13 @@ try {
380380

381381
end_sign_files @(,$job1)
382382
Write-Output "Signing binaries Completed"
383-
384-
Copy-Item "$destdir\SignedBinaries" $bindir -Recurse -Force
385-
383+
386384
submit_symbols "NTVS$spacename" "$buildnumber $($targetvs.name)" "binaries" "$destdir\SignedBinaries" $symbol_contacts
387385

386+
#Copy the signed binaries back into the binaries directory
387+
# so that msi's are built with the signed binaries
388+
Copy-Item "$destdir\SignedBinaries\*" $bindir -Recurse -Force
389+
388390
foreach ($cmd in (Get-Content "BuildRelease.$config.$($targetVs.number).log") | Select-String "light.exe.+-out") {
389391
$targetdir = [regex]::Match($cmd, 'Nodejs\\Setup\\([^\\]+)').Groups[1].Value
390392

Nodejs/Tests/Utilities.UI/TestUtilities.UI.Nodejs.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
<Reference Include="Microsoft.VisualStudio.Text.UI, Version=$(VSTarget).0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL" />
5959
<Reference Include="Microsoft.VisualStudio.Text.UI.Wpf, Version=$(VSTarget).0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL" />
6060
<Reference Include="Microsoft.VisualStudio.TextManager.Interop, Version=7.1.40304.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" />
61-
<Reference Include="Microsoft.VisualStudio.TextManager.Interop.$(VSTarget).0, Version=$(VSTarget).0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
61+
<Reference Include="Microsoft.VisualStudio.TextManager.Interop.$(VSTarget), Version=$(VSTarget).0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
6262
<EmbedInteropTypes>True</EmbedInteropTypes>
6363
</Reference>
6464
<Reference Include="PresentationCore" />

0 commit comments

Comments
 (0)