feat: roll driver to 1.3.0-next.1596843106133, handle paths on the client side

Author: dgozman

README.md

@@ -1,6 +1,6 @@
 # 🎭 [Playwright](https://github.com/microsoft/playwright) for Python
 
-[![PyPI version](https://badge.fury.io/py/playwright.svg)](https://pypi.python.org/pypi/playwright/) [![Join Slack](https://img.shields.io/badge/join-slack-infomational)](https://join.slack.com/t/playwright/shared_invite/enQtOTEyMTUxMzgxMjIwLThjMDUxZmIyNTRiMTJjNjIyMzdmZDA3MTQxZWUwZTFjZjQwNGYxZGM5MzRmNzZlMWI5ZWUyOTkzMjE5Njg1NDg) <!-- GEN:chromium-version-badge -->[![Chromium version](https://img.shields.io/badge/chromium-86.0.4217.0-blue.svg?logo=google-chrome)](https://www.chromium.org/Home)<!-- GEN:stop --> <!-- GEN:firefox-version-badge -->[![Firefox version](https://img.shields.io/badge/firefox-78.0b5-blue.svg?logo=mozilla-firefox)](https://www.mozilla.org/en-US/firefox/new/)<!-- GEN:stop --> [![WebKit version](https://img.shields.io/badge/webkit-14.0-blue.svg?logo=safari)](https://webkit.org/)
+[![PyPI version](https://badge.fury.io/py/playwright.svg)](https://pypi.python.org/pypi/playwright/) [![Join Slack](https://img.shields.io/badge/join-slack-infomational)](https://join.slack.com/t/playwright/shared_invite/enQtOTEyMTUxMzgxMjIwLThjMDUxZmIyNTRiMTJjNjIyMzdmZDA3MTQxZWUwZTFjZjQwNGYxZGM5MzRmNzZlMWI5ZWUyOTkzMjE5Njg1NDg) <!-- GEN:chromium-version-badge -->[![Chromium version](https://img.shields.io/badge/chromium-86.0.4217.0-blue.svg?logo=google-chrome)](https://www.chromium.org/Home)<!-- GEN:stop --> <!-- GEN:firefox-version-badge -->[![Firefox version](https://img.shields.io/badge/firefox-79.0a1-blue.svg?logo=mozilla-firefox)](https://www.mozilla.org/en-US/firefox/new/)<!-- GEN:stop --> [![WebKit version](https://img.shields.io/badge/webkit-14.0-blue.svg?logo=safari)](https://webkit.org/)
 [![Coverage Status](https://coveralls.io/repos/github/microsoft/playwright-python/badge.svg?branch=master)](https://coveralls.io/github/microsoft/playwright-python?branch=master)
 
 ##### [Docs](#documentation) | [API reference](https://github.com/microsoft/playwright/blob/master/docs/api.md)
@@ -11,7 +11,7 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H
 |   :---   | :---: | :---: | :---:   |
 | Chromium <!-- GEN:chromium-version -->86.0.4217.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 | WebKit 14.0 | ✅ | ✅ | ✅ |
-| Firefox <!-- GEN:firefox-version -->78.0b5<!-- GEN:stop --> | ✅ | ✅ | ✅ |
+| Firefox <!-- GEN:firefox-version -->79.0a1<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 
 Headless execution is supported for all the browsers on all platforms.
 

driver/package.json

@@ -13,7 +13,7 @@
   },
   "license": "Apache-2.0",
   "dependencies": {
-    "playwright": "1.3.0-next.1596659749397"
+    "playwright": "1.3.0-next.1596843106133"
   },
   "devDependencies": {
     "pkg": "^4.4.9"

playwright/drivers/browsers.json

@@ -8,7 +8,7 @@
     },
     {
       "name": "firefox",
-      "revision": "1144",
+      "revision": "1154",
       "download": true
     },
     {

playwright/page.py

@@ -539,8 +539,15 @@ async def screenshot(
         fullPage: bool = None,
         clip: FloatRect = None,
     ) -> bytes:
-        binary = await self._channel.send("screenshot", locals_to_params(locals()))
-        return base64.b64decode(binary)
+        params = locals_to_params(locals())
+        if "path" in params:
+            del params["path"]
+        encoded_binary = await self._channel.send("screenshot", params)
+        decoded_binary = base64.b64decode(encoded_binary)
+        if path:
+            with open(path, "wb") as fd:
+                fd.write(decoded_binary)
+        return decoded_binary
 
     async def title(self) -> str:
         return await self._main_frame.title()
@@ -722,7 +729,8 @@ async def pdf(
         path: str = None,
     ) -> bytes:
         params = locals_to_params(locals())
-        del params["path"]
+        if "path" in params:
+            del params["path"]
         encoded_binary = await self._channel.send("pdf", params)
         decoded_binary = base64.b64decode(encoded_binary)
         if path:

tests/async/test_pdf.py

@@ -25,3 +25,9 @@ async def test_should_be_able_to_save_pdf_file(page: Page, server, tmpdir: Path)
     output_file = tmpdir / "foo.png"
     await page.pdf(path=str(output_file))
     assert os.path.getsize(output_file) > 0
+
+
+@pytest.mark.only_browser("chromium")
+async def test_should_be_able_capture_pdf_without_path(page: Page):
+    buffer = await page.pdf()
+    assert buffer

tests/sync/test_pdf.py

@@ -25,3 +25,9 @@ def test_should_be_able_to_save_pdf_file(page: Page, server, tmpdir: Path):
     output_file = tmpdir / "foo.png"
     page.pdf(path=str(output_file))
     assert os.path.getsize(output_file) > 0
+
+
+@pytest.mark.only_browser("chromium")
+def test_should_be_able_capture_pdf_without_path(page: Page):
+    buffer = page.pdf()
+    assert buffer