From d5cd654cef0514185e1a0c20d6a7601e977766b9 Mon Sep 17 00:00:00 2001 From: "Ross A. Wollman" Date: Mon, 4 Jul 2022 12:27:29 -0700 Subject: [PATCH] test: skip broken FF nav test --- tests/async/test_har.py | 5 +++-- tests/sync/test_har.py | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/async/test_har.py b/tests/async/test_har.py index 55c28e91a..cd1c871a6 100644 --- a/tests/async/test_har.py +++ b/tests/async/test_har.py @@ -20,7 +20,6 @@ from pathlib import Path import pytest -from flaky import flaky from playwright.async_api import Browser, BrowserContext, Error, Page, Route, expect from tests.server import Server @@ -437,7 +436,9 @@ async def test_should_go_back_to_redirected_navigation( assert await page.evaluate("window.location.href") == "https://www.theverge.com/" -@flaky(max_runs=5) # Flaky upstream +@pytest.mark.skip_browser( + "firefox" +) # skipped upstream (https://github.com/microsoft/playwright/blob/6a8d835145e2f4002ee00b67a80a1f70af956703/tests/library/browsercontext-har.spec.ts#L214) async def test_should_go_forward_to_redirected_navigation( context: BrowserContext, server: Server, assetdir: Path ) -> None: diff --git a/tests/sync/test_har.py b/tests/sync/test_har.py index f8eb26091..81452c9de 100644 --- a/tests/sync/test_har.py +++ b/tests/sync/test_har.py @@ -20,7 +20,6 @@ from typing import Any, cast import pytest -from flaky import flaky from playwright.sync_api import Browser, BrowserContext, Error, Page, Route, expect from tests.server import Server @@ -374,7 +373,9 @@ def test_should_go_back_to_redirected_navigation( assert page.evaluate("window.location.href") == "https://www.theverge.com/" -@flaky(max_runs=5) # Flaky upstream +@pytest.mark.skip_browser( + "firefox" +) # skipped upstream (https://github.com/microsoft/playwright/blob/6a8d835145e2f4002ee00b67a80a1f70af956703/tests/library/browsercontext-har.spec.ts#L214) def test_should_go_forward_to_redirected_navigation( context: BrowserContext, server: Server, assetdir: Path ) -> None: