Skip to content

[Feature] Automagically Run xvfb-run if no DISPLAY set and head full #9888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwoll opened this issue Oct 29, 2021 · 1 comment
Closed

[Feature] Automagically Run xvfb-run if no DISPLAY set and head full #9888

rwoll opened this issue Oct 29, 2021 · 1 comment

Comments

@rwoll
Copy link
Member

rwoll commented Oct 29, 2021

In slack, it's fairly common to see folks get the DISPLAY error in CI/CD, so it might be friendlier to auto detect this and automatically wrap the browser launch in xvfb-run internally in Playwright so it's transparent for the user.

Since our setup has a mix of headful and headless projects, we just always wrap our test launches with xvfb-run so we don't have to have conditional logic dealing with each of the different projects. If playwright auto detected the need for xvfb-run wrap, we wouldn't need waste calling it AND we wouldn't have to remember to add xvfb-run wrap when we add new CI/CD workflows.

@mxschmitt
Copy link
Member

Relates #6037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants