You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Part of #1402 masks the fact that when we call a function, we declare parameters inside of the scope of the function (DeclareParametersInScope) before evaluating it, but never "undo" that work. This means that we may leave traces of an old analysis around. This is particularly bad for the builtins module, whose scopes are never cleared.
The way we evaluate functions with parameters should be modified to either:
Restore the old parameters or remove the parameters after calling. This will likely need to be locked so two parallel calls to the same function don't cause weirdness.
Create a wrapper scope to evaluate the function body in that can be thrown away. This would lack the locking requirement, but many places do casts from IScope to concrete types and would break.
The text was updated successfully, but these errors were encountered:
Uh oh!
There was an error while loading. Please reload this page.
Part of #1402 masks the fact that when we call a function, we declare parameters inside of the scope of the function (
DeclareParametersInScope
) before evaluating it, but never "undo" that work. This means that we may leave traces of an old analysis around. This is particularly bad for the builtins module, whose scopes are never cleared.The way we evaluate functions with parameters should be modified to either:
IScope
to concrete types and would break.The text was updated successfully, but these errors were encountered: