Skip to content

Commit 1f3789c

Browse files
Saadnajmipull[bot]ryanlntnntremganandraj
authored
Fix "Debugger unavailable" message (#1143)
* add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * [pull] master from microsoft:master (#11) * Deprecated api (#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (#855) * add pull yml * match handleOpenURLNotification event payload with iOS (#755) (#2) Co-authored-by: Ryan Linton <[email protected]> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> * Grammar fixes. (#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Saad Najmi <[email protected]> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]> * Fix alert * Delete extra file Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <[email protected]> Co-authored-by: Nick Trescases <[email protected]> Co-authored-by: Anandraj <[email protected]> Co-authored-by: Muhammad Hamza Zaman <[email protected]>
1 parent f6a25a1 commit 1f3789c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

React/CoreModules/RCTDevMenu.mm

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -297,10 +297,10 @@ - (void)setDefaultJSBundle
297297
addObject:[RCTDevMenuItem
298298
buttonItemWithTitle:@"Debugger Unavailable"
299299
handler:^{
300-
#if !TARGET_OS_OSX // TODO(macOS GH#774)
301300
NSString *message = RCTTurboModuleEnabled()
302301
? @"Debugging with Chrome is not supported when TurboModules are enabled."
303302
: @"Include the RCTWebSocket library to enable JavaScript debugging.";
303+
#if !TARGET_OS_OSX // TODO(macOS GH#774)
304304
UIAlertController *alertController =
305305
[UIAlertController alertControllerWithTitle:@"Debugger Unavailable"
306306
message:message
@@ -319,10 +319,10 @@ - (void)setDefaultJSBundle
319319
completion:NULL];
320320
#else // [TODO(macOS GH#774)
321321
NSAlert *alert = [[NSAlert alloc] init];
322-
[alert setMessageText:@"Remote JS Debugger Unavailable"];
323-
[alert setInformativeText:@"You need to include the RCTWebSocket library to enable remote JS debugging"];
322+
[alert setMessageText:@"Debugger Unavailable"];
323+
[alert setInformativeText:message];
324324
[alert addButtonWithTitle:@"OK"];
325-
[alert setAlertStyle:NSWarningAlertStyle];
325+
[alert setAlertStyle:NSAlertStyleWarning];
326326
[alert beginSheetModalForWindow:[NSApp keyWindow] completionHandler:nil];
327327
#endif // ]TODO(macOS GH#774)
328328
}]];

0 commit comments

Comments
 (0)