Skip to content

Commit 4a0a573

Browse files
rohitjain85acoates-ms
authored andcommitted
Moving v8 modules to third-party folder (#10)
* Moving v8 modules to third-party folder * Test commit to poke circleci
1 parent 680c673 commit 4a0a573

File tree

7 files changed

+4
-17
lines changed

7 files changed

+4
-17
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1 @@
1-
Libraries/Animated/* @janicduplessis
2-
Libraries/NativeAnimation/* @janicduplessis
3-
Libraries/Image/* @shergin
4-
Libraries/Text/* @shergin
5-
React/Base/* @shergin
6-
React/Views/* @shergin
7-
React/Modules/* @shergin
8-
React/CxxBridge/* @mhorowitz
9-
ReactAndroid/src/main/java/com/facebook/react/animated/* @janicduplessis
10-
**/*.md @hramos
11-
package.json @hramos
12-
local-cli/core/* @grabbou @kureev
13-
local-cli/link/* @grabbou @kureev
14-
local-cli/unlink/* @grabbou @kureev
1+
** @acoates-ms

ReactAndroid/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ task buildReactNdkLib(dependsOn: [prepareBoost, prepareDoubleConversion, prepare
204204
'NDK_OUT=' + temporaryDir,
205205
"NDK_LIBS_OUT=$buildDir/react-ndk/all",
206206
"THIRD_PARTY_NDK_DIR=$buildDir/third-party-ndk",
207-
"REACT_V8_DIR=$projectDir/src/main/jni/v8",
207+
"THIRD_PARTY_NDK_SRC_DIR=$projectDir/src/main/jni/third-party",
208208
"V8_NUGET_DIR=$projectDir/$V8Path",
209209
"REACT_COMMON_DIR=$projectDir/../ReactCommon",
210210
"REACT_SRC_DIR=$projectDir/src/main/java/com/facebook/react",
@@ -216,7 +216,7 @@ task cleanReactNdkLib(type: Exec) {
216216
commandLine getNdkBuildFullPath(),
217217
"NDK_APPLICATION_MK=$projectDir/src/main/jni/Application.mk",
218218
"THIRD_PARTY_NDK_DIR=$buildDir/third-party-ndk",
219-
"REACT_V8_DIR=$projectDir/src/main/jni/v8",
219+
"THIRD_PARTY_NDK_SRC_DIR=$projectDir/src/main/jni/third-party",
220220
"V8_NUGET_DIR=$projectDir/$V8Path",
221221
"REACT_COMMON_DIR=$projectDir/../ReactCommon",
222222
"REACT_SRC_DIR=$projectDir/src/main/java/com/facebook/react",

ReactAndroid/src/main/jni/Application.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ APP_PLATFORM := android-16
55

66
APP_MK_DIR := $(dir $(lastword $(MAKEFILE_LIST)))
77

8-
NDK_MODULE_PATH := $(APP_MK_DIR)$(HOST_DIRSEP)$(THIRD_PARTY_NDK_DIR)$(HOST_DIRSEP)$(REACT_COMMON_DIR)$(HOST_DIRSEP)$(APP_MK_DIR)first-party$(HOST_DIRSEP)$(REACT_V8_DIR)$(HOST_DIRSEP)$(REACT_V8_DIR)/../v8base$(HOST_DIRSEP)$(REACT_V8_DIR)/../v8platform
8+
NDK_MODULE_PATH := $(APP_MK_DIR)$(HOST_DIRSEP)$(THIRD_PARTY_NDK_DIR)$(HOST_DIRSEP)$(REACT_COMMON_DIR)$(HOST_DIRSEP)$(APP_MK_DIR)first-party$(HOST_DIRSEP)$(THIRD_PARTY_NDK_SRC_DIR)$(HOST_DIRSEP)
99

1010
APP_STL := gnustl_shared
1111

0 commit comments

Comments
 (0)