Skip to content

Commit c5ab90f

Browse files
authored
ci: set the npm dist-tag in nx release publish (#2484)
## Summary: We separate our CI to run `nx release` as two steps: `nx release --skip-publish` and `nx release publish`. The latter seems to not pick up the NPM dist-tag we want to set packages to release with, so it defaults to `latest`. This seems solvable by simply passing in `--tag`., since that gets picked up [in this line of code](https://github.com/nrwl/nx/blob/745abdaecfffbf09278dd576ef32afb8a7da9735/packages/js/src/executors/release-publish/release-publish.impl.ts#L123). ## Test Plan: Locally ran `nx release-publish` with extra console.logs to make sure the tag was passed in.
1 parent 7bb5df3 commit c5ab90f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.ado/templates/npm-publish-steps.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ steps:
4242
4343
- script: |
4444
if [[ -f .rnm-publish ]]; then
45-
yarn nx release publish --excludeTaskDependencies
45+
yarn nx release publish --tag ${{ parameters['publishTag'] }} --excludeTaskDependencies
4646
fi
4747
displayName: Publish packages
4848
condition: and(succeeded(), eq(variables['publish_react_native_macos'], '1'))

0 commit comments

Comments
 (0)