Skip to content

Commit d9bcca9

Browse files
authored
Merge pull request #1241 from rasaha91/cherry-pick-rn-tester-fixes
Cherry pick rn tester fixes
2 parents aa82e60 + 43861ac commit d9bcca9

File tree

2 files changed

+80
-0
lines changed

2 files changed

+80
-0
lines changed
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
diff --git a/packages/rn-tester/android/app/build.gradle b/packages/rn-tester/android/app/build.gradle
2+
index cf7a24b4648..31c2060be9e 100644
3+
--- a/packages/rn-tester/android/app/build.gradle
4+
+++ b/packages/rn-tester/android/app/build.gradle
5+
@@ -95,7 +95,7 @@ react {
6+
7+
project.ext.react = [
8+
enableCodegen: true, // Keep this here until it's sync'ed to Android template.
9+
- enableFabric: (System.getenv('USE_FABRIC') ?: 'true').toBoolean()
10+
+ enableFabric: false
11+
]
12+
13+
//apply from: "../../../../react.gradle"
14+
@@ -162,6 +162,9 @@ android {
15+
jsc {
16+
dimension "vm"
17+
}
18+
+ v8 {
19+
+ dimension "vm"
20+
+ }
21+
}
22+
23+
defaultConfig {
Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
diff --git a/packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterApplication.java b/packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterApplication.java
2+
index 1a393ce051d..129a4a8dea2 100644
3+
--- a/packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterApplication.java
4+
+++ b/packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterApplication.java
5+
@@ -7,11 +7,15 @@
6+
7+
package com.facebook.react.uiapp;
8+
9+
+import static com.facebook.react.modules.systeminfo.AndroidInfoHelpers.getFriendlyDeviceName;
10+
+
11+
import android.app.Application;
12+
import android.content.Context;
13+
import androidx.annotation.NonNull;
14+
import androidx.annotation.Nullable;
15+
import com.facebook.fbreact.specs.SampleTurboModule;
16+
+import com.facebook.hermes.reactexecutor.HermesExecutorFactory;
17+
+import com.facebook.react.jscexecutor.JSCExecutorFactory;
18+
import com.facebook.react.ReactApplication;
19+
import com.facebook.react.ReactInstanceManager;
20+
import com.facebook.react.ReactNativeHost;
21+
@@ -23,6 +27,7 @@ import com.facebook.react.bridge.JSIModuleProvider;
22+
import com.facebook.react.bridge.JSIModuleSpec;
23+
import com.facebook.react.bridge.JSIModuleType;
24+
import com.facebook.react.bridge.JavaScriptContextHolder;
25+
+import com.facebook.react.bridge.JavaScriptExecutorFactory;
26+
import com.facebook.react.bridge.NativeModule;
27+
import com.facebook.react.bridge.ReactApplicationContext;
28+
import com.facebook.react.bridge.UIManager;
29+
@@ -38,6 +43,7 @@ import com.facebook.react.uiapp.component.MyNativeViewManager;
30+
import com.facebook.react.uimanager.ViewManager;
31+
import com.facebook.react.uimanager.ViewManagerRegistry;
32+
import com.facebook.react.views.text.ReactFontManager;
33+
+import com.facebook.react.v8executor.V8ExecutorFactory;
34+
import com.facebook.soloader.SoLoader;
35+
import java.lang.reflect.InvocationTargetException;
36+
import java.util.ArrayList;
37+
@@ -51,6 +57,20 @@ public class RNTesterApplication extends Application implements ReactApplication
38+
39+
private final ReactNativeHost mReactNativeHost =
40+
new ReactNativeHost(this) {
41+
+ @Override
42+
+ public JavaScriptExecutorFactory getJavaScriptExecutorFactory() {
43+
+ if (BuildConfig.FLAVOR.equals("hermes")) {
44+
+ return new HermesExecutorFactory();
45+
+ } else if (BuildConfig.FLAVOR.equals("v8")) {
46+
+ return new V8ExecutorFactory(getApplication().getPackageName(), getFriendlyDeviceName());
47+
+ } else if (BuildConfig.FLAVOR.equals("jsc")) {
48+
+ SoLoader.loadLibrary("jscexecutor");
49+
+ return new JSCExecutorFactory(getApplication().getPackageName(), getFriendlyDeviceName());
50+
+ } else {
51+
+ throw new IllegalArgumentException("Missing handler in getJavaScriptExecutorFactory for build flavor: " + BuildConfig.FLAVOR);
52+
+ }
53+
+ }
54+
+
55+
@Override
56+
public String getJSMainModuleName() {
57+
return "packages/rn-tester/js/RNTesterApp.android";

0 commit comments

Comments
 (0)