Skip to content

Warning Box should not be visible in Release mode #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericvicenti opened this issue Nov 18, 2021 · 3 comments
Closed

Warning Box should not be visible in Release mode #905

ericvicenti opened this issue Nov 18, 2021 · 3 comments
Labels
bug Something isn't working Needs: Author Feedback

Comments

@ericvicenti
Copy link

Environment

react-native-macos: 0.64.10

Steps to reproduce the bug

Build an app in release mode with npx react-native run-macos --configuration Release. Then cause a warning to happen

One easy way to trigger a warning (this should probably be a separate issue):

  • Set a Text component to selectable=true
  • Right click on the text component so the "copy" option is visible
  • Click elsewhere in the application
  • The following warning will appear (even in release mode!)

Screen Shot 2021-11-18 at 11 17 18 AM

Expected Behavior

Warnings should be silently ignored in release mode

Actual Behavior

Screen Shot 2021-11-18 at 11 17 18 AM

Reproducible Demo

No response

Additional context

No response

@ericvicenti ericvicenti added the bug Something isn't working label Nov 18, 2021
@ghost ghost added the Needs: Triage 🔍 label Nov 18, 2021
@HeyImChris
Copy link

Thanks for filing this! I'm seeing this behavior too in the rn-tester project. Seems like a good bug worth looking in to.

@HeyImChris
Copy link

Could you try to repro this again on 0.64.14 or later? A fix went in to disable dev mode in release builds recently that might impact this.

@HeyImChris
Copy link

Just verified that we no longer show debug LogBoxes in release builds as of commit 2bb6d93ed6443c0fbbddf2748deb2945316cb7ce so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs: Author Feedback
Projects
None yet
Development

No branches or pull requests

2 participants