Skip to content

Wrong cursor on hover for TextInput multiline={false} editable={false} #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbcullis opened this issue Dec 12, 2021 · 9 comments
Closed
Labels
bug Something isn't working Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot)

Comments

@jbcullis
Copy link

Environment

react-native 0.64.0:
npm ls react-native-macos: 0.64.13
node: 17.0.1
npm: 8.1.0
yarn: N/A
xcodebuild: 13A1030d

Steps to reproduce the bug

Create the following text input:

Hover over and the cursor stays as the text selection cursor.

Expected Behavior

When editable is false, mouse should revert to default cursor.

Actual Behavior

Cursor remains as text selection cursor.

Reproducible Demo

No response

Additional context

No response

@jbcullis jbcullis added the bug Something isn't working label Dec 12, 2021
@ghost ghost added the Needs: Triage 🔍 label Dec 12, 2021
@HeyImChris
Copy link

@jbcullis Would you mind linking a sample project we can repro this with?

@jbcullis
Copy link
Author

jbcullis commented Jan 3, 2022

Will do @HeyImChris - on the road this week but will get a sample up this weekend.

@ghost ghost added Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) and removed Needs: Author Feedback labels Jan 3, 2022
@harrieshin
Copy link

@mischreiber / @Saadnajmi : #760 does this address this issue?

@Saadnajmi
Copy link
Collaborator

Saadnajmi commented Oct 19, 2022

EDIT: Sorry this is multiline text input. So it wouldn't have been #760. I think we fixed this recently with a different PR. I'l double check our recent commits. A lot of new work was done on multiline textinput that is merged in our main branch and will be in our next major release (0.70)

@shwanton
Copy link

Now that #1346 is merged, we will add cursor customization for NSTextView like #760

@Saadnajmi
Copy link
Collaborator

Sorry @shwanton I thought this issue was about Text, it's actually about TextInput, so I don't think your change is applicable. I looked at our last few commits and I didn't see any obvious change that fixes this particular issue. @jbcullis could you confirm you still have this on the latest main commit?

@shwanton
Copy link

Ah, my bad! I didn't realize this was for TextInput.

@jbcullis
Copy link
Author

@Saadnajmi will do, just need a couple days to get the project on latest.

@jbcullis jbcullis closed this as completed Nov 8, 2022
@jbcullis
Copy link
Author

jbcullis commented Nov 8, 2022

Resolved in 68.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot)
Projects
None yet
Development

No branches or pull requests

5 participants