Skip to content

JsonRPC protocol epic issue #5490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Youssef1313 opened this issue Apr 21, 2025 · 0 comments
Open

JsonRPC protocol epic issue #5490

Youssef1313 opened this issue Apr 21, 2025 · 0 comments
Labels
Area: MTP Belongs to the Microsoft.Testing.Platform core library Area: Server Mode

Comments

@Youssef1313
Copy link
Member

Initialize request

  • initialize request has debuggerProvider capability, which the server doesn't make use of at all. This is also because the server never sends client/launchDebugger and client/attachDebugger requests. Should we remove those requests for now?
  • batchLoggingSupport is documented but not implemented both in Test Explorer and server. I think this should be removed from the documentation, until it's needed and implemented.
  • Client capabilities documents attachmentsSupport, but Test Explorer actually sends attachmentsProvider (always sends it as true). The server doesn't care about either of the two. I think this can be removed altogether.
  • Client capabilities documents callbackProvider, but this is not implemented both in TE and server.
  • On TE side, multipleConnectionProvider is part of client capabilities. On server side, it's part of server capabilities. And is not documented in both.

Initialize response

  • Both server and client has ProcessId as part of initialize response, which is not documented.
  • The documented capabilities are experimental_multiRequestSupport and attachmentsProvider.
    • TODO for me: Validate how experimental_multiRequestSupport is used.
    • Both client and server use attachmentsSupport, not attachmentsProvider
    • supportsDiscovery, vstestProvider, multipleConnectionProvider are part of server capabilities on the server implementation, but not documented (well, vstestProvider is documented in an extension document, but no mentioned in the main one)

TODO: Review the rest. So far I reviewed only the initialize part.

@Youssef1313 Youssef1313 added Area: MTP Belongs to the Microsoft.Testing.Platform core library Area: Server Mode labels Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: MTP Belongs to the Microsoft.Testing.Platform core library Area: Server Mode
Projects
None yet
Development

No branches or pull requests

1 participant