Address PR feedback: Rename function, use ptrTo(true), fix capabilities copying

Co-authored-by: DanielRosenwasser <[email protected]>

Author: Copilot

internal/lsp/server.go

@@ -722,7 +722,7 @@ func (s *Server) handleDefinition(ctx context.Context, params *lsproto.Definitio
 	project := s.projectService.EnsureDefaultProjectForURI(params.TextDocument.Uri)
 	languageService, done := project.GetLanguageServiceForRequest(ctx)
 	defer done()
-	return languageService.ProvideDefinition(ctx, params.TextDocument.Uri, params.Position, getDefinitionClientCapabilities(s.initializeParams))
+	return languageService.ProvideDefinition(ctx, params.TextDocument.Uri, params.Position, definitionCapabilities(s.initializeParams))
 }
 
 func (s *Server) handleTypeDefinition(ctx context.Context, params *lsproto.TypeDefinitionParams) (lsproto.TypeDefinitionResponse, error) {
@@ -879,30 +879,28 @@ func getCompletionClientCapabilities(params *lsproto.InitializeParams) *lsproto.
 	return params.Capabilities.TextDocument.Completion
 }
 
-func getDefinitionClientCapabilities(params *lsproto.InitializeParams) *lsproto.DefinitionClientCapabilities {
+func definitionCapabilities(params *lsproto.InitializeParams) *lsproto.DefinitionClientCapabilities {
 	if params == nil || params.Capabilities == nil || params.Capabilities.TextDocument == nil {
 		// Return default capabilities with LinkSupport enabled
-		linkSupport := true
 		return &lsproto.DefinitionClientCapabilities{
-			LinkSupport: &linkSupport,
+			LinkSupport: ptrTo(true),
 		}
 	}
 
 	capabilities := params.Capabilities.TextDocument.Definition
 	if capabilities == nil {
 		// Return default capabilities with LinkSupport enabled
-		linkSupport := true
 		return &lsproto.DefinitionClientCapabilities{
-			LinkSupport: &linkSupport,
+			LinkSupport: ptrTo(true),
 		}
 	}
 
 	// If capabilities exist but LinkSupport is not specified, default to true
 	if capabilities.LinkSupport == nil {
-		linkSupport := true
-		return &lsproto.DefinitionClientCapabilities{
-			LinkSupport: &linkSupport,
-		}
+		// Copy existing capabilities and override LinkSupport
+		result := *capabilities
+		result.LinkSupport = ptrTo(true)
+		return &result
 	}
 
 	return capabilities