No error message shown in config UI for invalid compilerPath (#13529)

bobbrow · web-flow · commit 04bc6c82949e · 2025-04-17T11:12:26.000-07:00
diff --git a/Extension/src/LanguageServer/configurations.ts b/Extension/src/LanguageServer/configurations.ts
@@ -1612,7 +1612,7 @@ export class CppProperties {
             resolvedCompilerPath = which.sync(config.compilerPath, { nothrow: true });
         }
 
-        if (resolvedCompilerPath === undefined) {
+        if (!resolvedCompilerPath) {
             resolvedCompilerPath = this.resolvePath(config.compilerPath);
         }
         const settings: CppSettings = new CppSettings(this.rootUri);

Original file line number	Diff line number	Diff line change
`@@ -1612,7 +1612,7 @@ export class CppProperties {`
`1612`	`1612`	`resolvedCompilerPath = which.sync(config.compilerPath, { nothrow: true });`
`1613`	`1613`	`}`
`1614`	`1614`
`1615`		`- if (resolvedCompilerPath === undefined) {`
	`1615`	`+ if (!resolvedCompilerPath) {`
`1616`	`1616`	`resolvedCompilerPath = this.resolvePath(config.compilerPath);`
`1617`	`1617`	`}`
`1618`	`1618`	`const settings: CppSettings = new CppSettings(this.rootUri);`