Skip to content

Add guiEventLoop to launch.json schema #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bersbersbers opened this issue Dec 8, 2023 · 2 comments · Fixed by #243
Closed

Add guiEventLoop to launch.json schema #153

bersbersbers opened this issue Dec 8, 2023 · 2 comments · Fixed by #243
Assignees
@karthiknadig
Labels
feature-request Request for new features or functionality good first issue Good for newcomers needs PR Ready to be worked on

Comments

@bersbersbers
Copy link
Contributor

debugpy supports the guiEventLoop option, see microsoft/debugpy#1112, microsoft/debugpy#704, microsoft/debugpy#800, and https://github.com/microsoft/debugpy/blob/ef9a67fe150179ee4df9997f9273723c26687fab/src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_json_debug_options.py#L96C13-L97

However, the JSON schema does not include it, thus reporting

image

Related: microsoft/vscode-python#22406
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Dec 8, 2023
@eleanorjboyd eleanorjboyd added the feature-request Request for new features or functionality label Dec 11, 2023
@paulacamargo25 paulacamargo25 added needs community feedback and removed triage-needed Needs assignment to the proper sub-team labels Jan 30, 2024
@bersbersbers bersbersbers mentioned this issue Feb 29, 2024
Merged
@bersbersbers
Copy link
Contributor Author

May I ask what kind of "community feedback" is needed? Either way, I went ahead and submitted #243 to close this.

@paulacamargo25 paulacamargo25 added needs PR Ready to be worked on good first issue Good for newcomers and removed needs community feedback labels Mar 7, 2024
@paulacamargo25
Copy link
Contributor

Thanks for your PR @bersbersbers . Sorry it was my fault, the needs community feedback label is for every feature-request, in order to see if we'll implement the issue or not. But since this is a simple change, we can skip that step. I will check the PR. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karthiknadig karthiknadig

Labels
feature-request Request for new features or functionality good first issue Good for newcomers needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update launch.json schema
4 participants
@karthiknadig @bersbersbers @paulacamargo25 @eleanorjboyd