Skip to content

Commit 1cda783

Browse files
committed
Change property name used to track versions in telemetry (#2905)
For #2702
1 parent 2db710a commit 1cda783

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

src/client/activation/downloader.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export class LanguageServerDownloader implements ILanguageServerDownloader {
4545
public async downloadLanguageServer(context: IExtensionContext): Promise<void> {
4646
const downloadInfo = await this.getDownloadInfo();
4747
const downloadUri = downloadInfo.uri;
48-
const version = downloadInfo.version.raw;
48+
const lsVersion = downloadInfo.version.raw;
4949
const timer: StopWatch = new StopWatch();
5050
let success: boolean = true;
5151
let localTempFilePath = '';
@@ -61,7 +61,7 @@ export class LanguageServerDownloader implements ILanguageServerDownloader {
6161
sendTelemetryEvent(
6262
PYTHON_LANGUAGE_SERVER_DOWNLOADED,
6363
timer.elapsedTime,
64-
{ success, version }
64+
{ success, lsVersion }
6565
);
6666
}
6767

@@ -77,7 +77,7 @@ export class LanguageServerDownloader implements ILanguageServerDownloader {
7777
sendTelemetryEvent(
7878
PYTHON_LANGUAGE_SERVER_EXTRACTED,
7979
timer.elapsedTime,
80-
{ success, version }
80+
{ success, lsVersion }
8181
);
8282
await this.fs.deleteFile(localTempFilePath);
8383
}

src/client/interpreter/configuration/pythonPathUpdaterService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export class PythonPathUpdaterService implements IPythonPathUpdaterServiceManage
5050
.catch<string>(() => '');
5151
const [info, pipVersion] = await Promise.all([infoPromise, pipVersionPromise]);
5252
if (info) {
53-
telemtryProperties.version = info.version;
53+
telemtryProperties.pyVersion = info.version;
5454
}
5555
if (pipVersion) {
5656
telemtryProperties.pipVersion = pipVersion;

src/client/telemetry/types.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ export type FormatTelemetry = {
1717

1818
export type LanguageServerTelemetry = {
1919
success: boolean;
20+
lsVersion?: string;
2021
};
2122

2223
export type LinterTrigger = 'auto' | 'save';
@@ -30,7 +31,7 @@ export type LintingTelemetry = {
3031
export type PythonInterpreterTelemetry = {
3132
trigger: 'ui' | 'shebang' | 'load';
3233
failed: boolean;
33-
version?: string;
34+
pyVersion?: string;
3435
pipVersion?: string;
3536
};
3637
export type CodeExecutionTelemetry = {

0 commit comments

Comments
 (0)