Skip to content

Commit 2cd2092

Browse files
authored
Fixed a bug where pylance not working on interactive window. (#20831)
https://github.com/microsoft/vscode-python/pull/20816/files#diff-ba59d9ca0a087381d63119a88751fdc7c0aa07e6a10e772d3aefd4c10aa36fcfL47 this should have changed to return `false` rather than deleting since it would have been always return `false`. deleting effectively made it to have the same effect as always returning `true` follow up PR of #20816
1 parent d3dd832 commit 2cd2092

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/client/activation/languageClientMiddleware.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export class LanguageClientMiddleware extends LanguageClientMiddlewareBase {
4242
);
4343
}
4444

45-
private shouldCreateHidingMiddleware(jupyterDependencyManager: IJupyterExtensionDependencyManager): boolean {
45+
protected shouldCreateHidingMiddleware(jupyterDependencyManager: IJupyterExtensionDependencyManager): boolean {
4646
return jupyterDependencyManager && jupyterDependencyManager.isJupyterExtensionInstalled;
4747
}
4848

src/client/activation/node/languageClientMiddleware.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,11 @@ export class NodeLanguageClientMiddleware extends LanguageClientMiddleware {
4444
}
4545
}
4646

47+
// eslint-disable-next-line class-methods-use-this
48+
protected shouldCreateHidingMiddleware(_: IJupyterExtensionDependencyManager): boolean {
49+
return false;
50+
}
51+
4752
protected async onExtensionChange(jupyterDependencyManager: IJupyterExtensionDependencyManager): Promise<void> {
4853
if (jupyterDependencyManager && jupyterDependencyManager.isJupyterExtensionInstalled) {
4954
await this.lspNotebooksExperiment.onJupyterInstalled();

0 commit comments

Comments
 (0)