Remove experiments for refresh and failed tests buttons (#17894)

* Removing experiments for refresh and failed tests buttons

* move news item to code health

Author: karthiknadig

news/3 Code Health/17868.md

@@ -0,0 +1 @@
+Removing experiments for refresh and failed tests buttons.

package.json

@@ -506,8 +506,6 @@
                             "pythonDeprecatePythonPath",
                             "pythonSurveyNotification",
                             "pythonTensorboardExperiment",
-                            "pythonRunFailedTestsButtonDisplayed",
-                            "pythonRefreshTestsButtonDisplayed",
                             "pythonRememberDebugConfig"
                         ]
                     },
@@ -523,8 +521,6 @@
                             "pythonDeprecatePythonPath",
                             "pythonSurveyNotification",
                             "pythonTensorboardExperiment",
-                            "pythonRunFailedTestsButtonDisplayed",
-                            "pythonRefreshTestsButtonDisplayed",
                             "pythonRememberDebugConfig"
                         ]
                     },
@@ -1840,22 +1836,22 @@
             "view/title": [
                 {
                     "command": "python.refreshTests",
-                    "when": "view == workbench.view.testing && !refreshingTests && inShowRefreshingTestsExperiment && !virtualWorkspace && shellExecutionSupported",
+                    "when": "view == workbench.view.testing && !refreshingTests && !virtualWorkspace && shellExecutionSupported",
                     "group": "navigation@0"
                 },
                 {
                     "command": "python.refreshingTests",
-                    "when": "view == workbench.view.testing && refreshingTests && inShowRefreshingTestsExperiment && !virtualWorkspace && shellExecutionSupported",
+                    "when": "view == workbench.view.testing && refreshingTests && !virtualWorkspace && shellExecutionSupported",
                     "group": "navigation@0"
                 },
                 {
                     "command": "python.stopRefreshingTests",
-                    "when": "view == workbench.view.testing && refreshingTests && inShowRefreshingTestsExperiment && !virtualWorkspace && shellExecutionSupported",
+                    "when": "view == workbench.view.testing && refreshingTests && !virtualWorkspace && shellExecutionSupported",
                     "group": "navigation@0"
                 },
                 {
                     "command": "testing.reRunFailTests",
-                    "when": "view == workbench.view.testing && hasFailedTests && inShowRunFailedTestsExperiment && !virtualWorkspace && shellExecutionSupported",
+                    "when": "view == workbench.view.testing && hasFailedTests && !virtualWorkspace && shellExecutionSupported",
                     "group": "navigation@1"
                 }
             ]

src/client/common/application/contextKeys.ts

@@ -3,7 +3,5 @@
 
 export enum ExtensionContextKey {
     HasFailedTests = 'hasFailedTests',
-    InShowRunFailedTestsExperiment = 'inShowRunFailedTestsExperiment',
     RefreshingTests = 'refreshingTests',
-    InShowRefreshingTestsExperiment = 'inShowRefreshingTestsExperiment',
 }

src/client/common/experiments/groups.ts

@@ -29,16 +29,6 @@ export enum TorchProfiler {
     experiment = 'PythonPyTorchProfiler',
 }
 
-// Experiment to show the run failed tests button
-export enum ShowRunFailedTests {
-    experiment = 'pythonRunFailedTestsButtonDisplayed',
-}
-
-// Experiment to show the run failed tests button
-export enum ShowRefreshTests {
-    experiment = 'pythonRefreshTestsButtonDisplayed',
-}
-
 // Experiment to cache debug configuration
 export enum CacheDebugConfig {
     experiment = 'pythonRememberDebugConfig',

src/client/testing/main.ts

@@ -5,7 +5,7 @@ import { ConfigurationChangeEvent, Disposable, Uri, tests, TestResultState, Work
 import { IApplicationShell, ICommandManager, IContextKeyManager, IWorkspaceService } from '../common/application/types';
 import * as constants from '../common/constants';
 import '../common/extensions';
-import { IDisposableRegistry, IExperimentService, Product } from '../common/types';
+import { IDisposableRegistry, Product } from '../common/types';
 import { IInterpreterService } from '../interpreter/contracts';
 import { IServiceContainer } from '../ioc/types';
 import { EventName } from '../telemetry/constants';
@@ -18,7 +18,6 @@ import { IExtensionActivationService } from '../activation/types';
 import { ITestController } from './testController/common/types';
 import { traceVerbose } from '../common/logger';
 import { DelayedTrigger, IDelayedTrigger } from '../common/utils/delayTrigger';
-import { ShowRefreshTests, ShowRunFailedTests } from '../common/experiments/groups';
 import { ExtensionContextKey } from '../common/application/contextKeys';
 import { checkForFailedTests, updateTestResultMap } from './testController/common/testItemUtilities';
 import { Testing } from '../common/utils/localize';
@@ -112,17 +111,6 @@ export class UnitTestManagementService implements IExtensionActivationService {
                 }
             });
         }
-
-        // Enable buttons based on experiment
-        const experiments = this.serviceContainer.get<IExperimentService>(IExperimentService);
-        await this.context.setContext(
-            ExtensionContextKey.InShowRunFailedTestsExperiment,
-            await experiments.inExperiment(ShowRunFailedTests.experiment),
-        );
-        await this.context.setContext(
-            ExtensionContextKey.InShowRefreshingTestsExperiment,
-            await experiments.inExperiment(ShowRefreshTests.experiment),
-        );
     }
 
     private async updateTestUIButtons() {