Ensure selected interpreter doesn't change when the extension is loading when in experiment (#16391)

* Ensure configuration service is ready for use before using it

* Add news entry

Author: Kartik Raj

news/2 Fixes/16291.md

@@ -0,0 +1 @@
+Ensure selected interpreter doesn't change when the extension is starting up and in experiment.

src/client/common/configSettings.ts

@@ -619,7 +619,7 @@ export class PythonSettings implements IPythonSettings {
         }
     }
 
-    protected initialize(): void {
+    public initialize(): void {
         const onDidChange = () => {
             const currentConfig = this.workspace.getConfiguration('python', this.workspaceRoot);
             this.update(currentConfig);

src/client/common/types.ts

@@ -205,6 +205,7 @@ export interface IPythonSettings {
     readonly logging: ILoggingSettings;
     readonly useIsolation: boolean;
     readonly tensorBoard: ITensorBoardSettings | undefined;
+    initialize(): void;
 }
 
 export interface ITensorBoardSettings {

src/client/extensionActivation.ts

@@ -175,6 +175,8 @@ async function activateLegacy(ext: ExtensionState): Promise<ActivationResult> {
     const manager = serviceContainer.get<IExtensionActivationManager>(IExtensionActivationManager);
     context.subscriptions.push(manager);
 
+    // Settings are dependent on Experiment service, so we need to initialize it after experiments are activated.
+    serviceContainer.get<IConfigurationService>(IConfigurationService).getSettings().initialize();
     await interpreterManager
         .refresh(workspaceService.hasWorkspaceFolders ? workspaceService.workspaceFolders![0].uri : undefined)
         .catch((ex) => traceError('Python Extension: interpreterManager.refresh', ex));

src/test/common/configSettings/configSettings.pythonPath.unit.test.ts

@@ -27,7 +27,7 @@ suite('Python Settings - pythonPath', () => {
         protected getPythonExecutable(pythonPath: string) {
             return pythonPath;
         }
-        protected initialize() {
+        public initialize() {
             noop();
         }
     }

src/test/common/configSettings/configSettings.unit.test.ts

@@ -33,7 +33,7 @@ suite('Python Settings', async () => {
         public update(pythonSettings: WorkspaceConfiguration) {
             return super.update(pythonSettings);
         }
-        protected initialize() {
+        public initialize() {
             noop();
         }
     }