Skip to content

Commit 5007d03

Browse files
author
Kartik Raj
committed
Remove Interpereter version service
1 parent 1789823 commit 5007d03

File tree

5 files changed

+1
-127
lines changed

5 files changed

+1
-127
lines changed

src/client/interpreter/contracts.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@ import { PythonLocatorQuery } from '../pythonEnvironments/base/locator';
77
import { CondaEnvironmentInfo } from '../pythonEnvironments/common/environmentManagers/conda';
88
import { EnvironmentType, PythonEnvironment } from '../pythonEnvironments/info';
99

10-
export const IInterpreterVersionService = Symbol('IInterpreterVersionService');
11-
export interface IInterpreterVersionService {
12-
getVersion(pythonPath: string, defaultValue: string): Promise<string>;
13-
}
14-
1510
export type PythonEnvironmentsChangedEvent = {
1611
type?: FileChangeType;
1712
resource?: Uri;

src/client/interpreter/interpreterVersion.ts

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/client/interpreter/serviceRegistry.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,12 @@ import {
2323
IPythonPathUpdaterServiceFactory,
2424
IPythonPathUpdaterServiceManager,
2525
} from './configuration/types';
26-
import {
27-
IInterpreterDisplay,
28-
IInterpreterHelper,
29-
IInterpreterService,
30-
IInterpreterVersionService,
31-
IShebangCodeLensProvider,
32-
} from './contracts';
26+
import { IInterpreterDisplay, IInterpreterHelper, IInterpreterService, IShebangCodeLensProvider } from './contracts';
3327
import { InterpreterDisplay } from './display';
3428
import { InterpreterLocatorProgressStatubarHandler } from './display/progressDisplay';
3529
import { ShebangCodeLensProvider } from './display/shebangCodeLensProvider';
3630
import { InterpreterHelper } from './helpers';
3731
import { InterpreterService } from './interpreterService';
38-
import { InterpreterVersionService } from './interpreterVersion';
3932
import { CondaInheritEnvPrompt } from './virtualEnvs/condaInheritEnvPrompt';
4033
import { VirtualEnvironmentPrompt } from './virtualEnvs/virtualEnvPrompt';
4134

@@ -62,8 +55,6 @@ export function registerInterpreterTypes(serviceManager: IServiceManager): void
6255

6356
serviceManager.addSingleton<IExtensionActivationService>(IExtensionActivationService, VirtualEnvironmentPrompt);
6457

65-
serviceManager.addSingleton<IInterpreterVersionService>(IInterpreterVersionService, InterpreterVersionService);
66-
6758
serviceManager.addSingleton<IInterpreterService>(IInterpreterService, InterpreterService);
6859
serviceManager.addSingleton<IInterpreterDisplay>(IInterpreterDisplay, InterpreterDisplay);
6960

src/test/common/process/execFactory.test.ts

Lines changed: 0 additions & 91 deletions
This file was deleted.

src/test/interpreters/serviceRegistry.unit.test.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,13 @@ import {
3030
IInterpreterDisplay,
3131
IInterpreterHelper,
3232
IInterpreterService,
33-
IInterpreterVersionService,
3433
IShebangCodeLensProvider,
3534
} from '../../client/interpreter/contracts';
3635
import { InterpreterDisplay } from '../../client/interpreter/display';
3736
import { InterpreterLocatorProgressStatubarHandler } from '../../client/interpreter/display/progressDisplay';
3837
import { ShebangCodeLensProvider } from '../../client/interpreter/display/shebangCodeLensProvider';
3938
import { InterpreterHelper } from '../../client/interpreter/helpers';
4039
import { InterpreterService } from '../../client/interpreter/interpreterService';
41-
import { InterpreterVersionService } from '../../client/interpreter/interpreterVersion';
4240
import { registerTypes } from '../../client/interpreter/serviceRegistry';
4341
import { CondaInheritEnvPrompt } from '../../client/interpreter/virtualEnvs/condaInheritEnvPrompt';
4442
import { VirtualEnvironmentPrompt } from '../../client/interpreter/virtualEnvs/virtualEnvPrompt';
@@ -56,8 +54,6 @@ suite('Interpreters - Service Registry', () => {
5654

5755
[IExtensionActivationService, VirtualEnvironmentPrompt],
5856

59-
[IInterpreterVersionService, InterpreterVersionService],
60-
6157
[IInterpreterService, InterpreterService],
6258
[IInterpreterDisplay, InterpreterDisplay],
6359

0 commit comments

Comments
 (0)