Fix a test by using the old listdir behavior.

Author: ericsnowcurrently

src/client/common/platform/fileSystem.ts

@@ -80,6 +80,18 @@ export class FileSystem implements IFileSystem {
         return deferred.promise;
     }
 
+    public async listdir(root: string): Promise<string[]> {
+        return new Promise<string[]>(resolve => {
+            // Now look for Interpreters in this directory
+            fs.readdir(root, (err, names) => {
+                if (err) {
+                    return resolve([]);
+                }
+                resolve(names.map(name => path.join(root, name)));
+            });
+        });
+    }
+
     public getSubDirectories(rootDir: string): Promise<string[]> {
         return new Promise<string[]>(resolve => {
             fs.readdir(rootDir, async (error, files) => {

src/client/common/platform/types.ts

@@ -47,6 +47,7 @@ export interface IFileSystem {
     directoryExists(path: string): Promise<boolean>;
     createDirectory(path: string): Promise<void>;
     deleteDirectory(path: string): Promise<void>;
+    listdir(dirname: string): Promise<string[]>;
     getSubDirectories(rootDir: string): Promise<string[]>;
     getFiles(rootDir: string): Promise<string[]>;
     arePathsSame(path1: string, path2: string): boolean;

src/client/interpreter/locators/helpers.ts

@@ -9,10 +9,12 @@ import { IPipEnvServiceHelper } from './types';
 const CheckPythonInterpreterRegEx = IS_WINDOWS ? /^python(\d+(.\d+)?)?\.exe$/ : /^python(\d+(.\d+)?)?$/;
 
 export function lookForInterpretersInDirectory(pathToCheck: string, fs: IFileSystem): Promise<string[]> {
-    return fs.getFiles(pathToCheck)
+    // Technically, we should be able to use fs.getFiles().  However,
+    // that breaks some tests.  So we stick with the broader behavior.
+    return fs.listdir(pathToCheck)
         .then(subDirs => subDirs.filter(fileName => CheckPythonInterpreterRegEx.test(path.basename(fileName))))
         .catch(err => {
-            traceError('Python Extension (lookForInterpretersInDirectory.fs.getFiles):', err);
+            traceError('Python Extension (lookForInterpretersInDirectory.fs.listdir):', err);
             return [] as string[];
         });
 }

src/test/interpreters/locators/workspaceVirtualEnvService.test.ts

@@ -80,6 +80,7 @@ suite('Interpreters - Workspace VirtualEnv Service', function() {
     this.retries(0);
 
     const workspaceUri = IS_MULTI_ROOT_TEST ? Uri.file(path.join(multirootPath, 'workspace3')) : rootWorkspaceUri!;
+    // "workspace4 does not exist.
     const workspace4 = Uri.file(path.join(multirootPath, 'workspace4'));
     const venvs = new Venvs(workspaceUri.fsPath);