Don't use activate from inside conda environments

In contrast to virtualenv-created environments, conda environments are not activated from the inside. In constrast, the environment activation is done from the outside via the conda executable that created the environment.

Fixes #4402

Author: xhochy

src/client/interpreter/locators/services/condaService.ts

@@ -250,24 +250,14 @@ export class CondaService implements ICondaService {
         const condaExe = this.platform.isWindows ? 'conda.exe' : 'conda';
         const scriptsDir = this.platform.isWindows ? 'Scripts' : 'bin';
         const interpreterDir = interpreterPath ? path.dirname(interpreterPath) : '';
-        let condaPath = path.join(interpreterDir, condaExe);
-        if (await this.fileSystem.fileExists(condaPath)) {
-            return condaPath;
-        }
-        // Conda path has changed locations, check the new location in the scripts directory after checking
-        // the old location
-        condaPath = path.join(interpreterDir, scriptsDir, condaExe);
-        if (await this.fileSystem.fileExists(condaPath)) {
-            return condaPath;
-        }
 
         // Might be in a situation where this is not the default python env, but rather one running
         // from a virtualenv
         const envsPos = envName ? interpreterDir.indexOf(path.join('envs', envName)) : -1;
         if (envsPos > 0) {
             // This should be where the original python was run from when the environment was created.
             const originalPath = interpreterDir.slice(0, envsPos);
-            condaPath = path.join(originalPath, condaExe);
+            let condaPath = path.join(originalPath, condaExe);
 
             if (await this.fileSystem.fileExists(condaPath)) {
                 return condaPath;
@@ -279,6 +269,17 @@ export class CondaService implements ICondaService {
                 return condaPath;
             }
         }
+
+        let condaPath = path.join(interpreterDir, condaExe);
+        if (await this.fileSystem.fileExists(condaPath)) {
+            return condaPath;
+        }
+        // Conda path has changed locations, check the new location in the scripts directory after checking
+        // the old location
+        condaPath = path.join(interpreterDir, scriptsDir, condaExe);
+        if (await this.fileSystem.fileExists(condaPath)) {
+            return condaPath;
+        }
     }
 
     /**