Skip to content

Extension loads slower in dev version (when compared to current release version) #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DonJayamanne opened this issue Apr 13, 2018 · 3 comments
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone

Comments

@DonJayamanne
Copy link

DonJayamanne commented Apr 13, 2018

#1238 Check if there have been no performance regressions)

Based on initial analysis, the extension takes twice as long to load (without enabling the analysis engine).

MacBook, tested loading of extension 5 times.

  • Load times of current (release) version of extension:

    • ~550ms to load all npm packages
    • ~650ms to automatically set the interpreter
    • ~660ms to completely load and activate the extension (sometimes as low as 500ms)
  • Load times of current (dev) version of extension:

    • ~1,412ms to load all npm packages
    • ~1572ms to automatically set the interpreter
    • ~1588ms to completely load and activate the extension

@brettcannon @MikhailArkhipov

@DonJayamanne DonJayamanne added this to the April 2018 milestone Apr 13, 2018
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Apr 13, 2018
@brettcannon
Copy link
Member

So one of our npm dependencies has gotten slow to load?

@DonJayamanne
Copy link
Author

Doesn't look like it, looks more like our code.
Haven't had the chance to look into this.

@brettcannon brettcannon added type-perf and removed bug Issue identified by VS Code Team member as probable bug feature-request Request for new features or functionality labels Apr 20, 2018
@brettcannon brettcannon modified the milestones: April 2018, May 2018 May 2, 2018
@DonJayamanne
Copy link
Author

This is no longer an issue.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

2 participants