Skip to content

Fix Python tests on Windows #14023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DavidKutu opened this issue Sep 21, 2020 · 4 comments
Closed

Fix Python tests on Windows #14023

DavidKutu opened this issue Sep 21, 2020 · 4 comments
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority

Comments

@DavidKutu
Copy link

These 2 fails on CI on Windows

FAILED pythonFiles\tests\testing_tools\adapter\test_functional.py::PytestTests::test_discover_complex_default
FAILED pythonFiles\tests\testing_tools\adapter\test_functional.py::PytestTests::test_discover_complex_doctest

They are disabled for now.
@DavidKutu DavidKutu added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels Sep 21, 2020
@DavidKutu DavidKutu mentioned this issue Sep 21, 2020
Merged
@kimadeline
Copy link

Maybe related: #13850

@karthiknadig karthiknadig added needs PR important Issue identified as high-priority labels Sep 22, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 22, 2020
@karthiknadig karthiknadig added area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. and removed bug Issue identified by VS Code Team member as probable bug labels Sep 22, 2020
@karthiknadig karthiknadig mentioned this issue Sep 23, 2020
Merged
2 tasks
@ericsnowcurrently
Copy link

@DavidKutu, @karthiknadig, what is the actual problem and what changed in 3.9? The output of the two failing tests would help.

(I'm guessing the way that doctests are handled changed, perhaps related to the new parser in 3.9.)

@karthiknadig
Copy link
Member

The order of the properties in the json object changed. Particularly, parentid and relpath switched positions. That is about it.

@DavidKutu
Copy link
Author

Here's the output @ericsnowcurrently

https://dev.azure.com/ms/15ada779-3584-4085-91e5-330cdbbf3d49/_apis/build/builds/110529/logs/1930

@ghost ghost removed the needs PR label Sep 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ericsnowcurrently @karthiknadig @DavidKutu @kimadeline