Skip to content

Filenames identified by WindowsPathEnvVarLocator have an unexpected format. #15289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ericsnowcurrently opened this issue Feb 1, 2021 · 0 comments · Fixed by #15483
Closed

Filenames identified by WindowsPathEnvVarLocator have an unexpected format. #15289

ericsnowcurrently opened this issue Feb 1, 2021 · 0 comments · Fixed by #15483
Assignees
@karrtikr
Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority

Comments

@ericsnowcurrently
Copy link

ericsnowcurrently commented Feb 1, 2021 •
edited by karrtikr
Loading

Locators on WIndows have consistently provided executable filenames with ~ unexpanded and with case matching whatever the OS reported. However, executables located by WindowsPathEnvVarLocator are all lower-cased and ~ is expanded. It would probably make sense to get WindowsPathEnvVarLocator consistent with the other locators.

image

(See #15177 (comment).)
@ericsnowcurrently ericsnowcurrently added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-environments Features relating to handling interpreter environments labels Feb 1, 2021
@karthiknadig karthiknadig mentioned this issue Feb 4, 2021
Closed
@karrtikr karrtikr added the important Issue identified as high-priority label Feb 23, 2021
@karrtikr karrtikr self-assigned this Feb 23, 2021
@karrtikr karrtikr mentioned this issue Feb 23, 2021
Merged
@ghost ghost removed the needs PR label Feb 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not lowercase executable paths returned by Windows path locator karrtikr/vscode-python
2 participants
@ericsnowcurrently @karrtikr