Skip to content

Test code lenses do not disappear even after disabling the unit tests feature #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DonJayamanne opened this issue May 10, 2018 · 6 comments · Fixed by #16769
Closed

Test code lenses do not disappear even after disabling the unit tests feature #1654

DonJayamanne opened this issue May 10, 2018 · 6 comments · Fixed by #16769
Labels
area-testing bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
August 2021

Comments

@DonJayamanne
Copy link

  • Add tests
  • Discover tests
  • Test code lenses appear
  • Disable tests feature in VS Code settings
  • The tests code lenses are still visible
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR area-testing labels May 10, 2018
@DonJayamanne DonJayamanne added this to the June 2018 milestone May 10, 2018
@DonJayamanne DonJayamanne self-assigned this May 10, 2018
@DonJayamanne DonJayamanne removed this from the June 2018 milestone Jun 4, 2018
@dastagg

This comment has been minimized.

Sign in to view
@DonJayamanne

This comment has been minimized.

Sign in to view
@dastagg

This comment has been minimized.

Sign in to view
@DonJayamanne

This comment has been minimized.

Sign in to view
@DonJayamanne DonJayamanne removed their assignment Oct 31, 2018
@rspeer rspeer mentioned this issue Nov 14, 2018
Closed
@kimadeline
Copy link

Still happening in 2019.9.34911:

  • code lenses do not disappear when setting all python.testing.<framework>Enabled settings to false
  • test explorer in the side bar doesn't disappear either (when not part of the AlwaysDisplayTestExplorer experiment)

@kimadeline kimadeline removed their assignment Sep 12, 2019
@kimadeline
Copy link

Fixed by #16769, we don't have code lenses anymore:

image

@kimadeline kimadeline added the verified Verification succeeded label Jul 29, 2021
@karthiknadig karthiknadig mentioned this issue Jul 30, 2021
Merged
@karthiknadig karthiknadig added this to the August 2021 milestone Aug 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-testing bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
August 2021
Development

Successfully merging a pull request may close this issue.

Test UI update and deprecations karthiknadig/vscode-python
5 participants
@brettcannon @dastagg @DonJayamanne @karthiknadig @kimadeline