Skip to content

Test discovery flow is unusual/weird #17094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrieken opened this issue Aug 24, 2021 · 3 comments
Open

Test discovery flow is unusual/weird #17094

jrieken opened this issue Aug 24, 2021 · 3 comments
Assignees
Labels
area-testing feature-request Request for new features or functionality needs proposal Need to make some design decisions partner ask

Comments

@jrieken
Copy link
Member

jrieken commented Aug 24, 2021

Testing #17055

  • get into configuring python tests
  • the 2nd and 3rd steps are about configuring the test folder and pattern
  • 😕 the use of quick pick is confusing esp for picking a workspace folder

I wonder if this can be solved different, like use the native file picker or a setting with a reasonable default

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Aug 24, 2021
@karthiknadig karthiknadig removed their assignment Aug 24, 2021
@karthiknadig karthiknadig added area-testing feature-request Request for new features or functionality needs decision partner ask and removed triage-needed Needs assignment to the proper sub-team labels Aug 24, 2021
@chrisdias
Copy link

I found this list weird as well. What if I have tests in a file that don't follow the convention? I expected to see a list of files that were in my workspace, not a set of file patterns. Maybe its because the file pattern is bold and the description is grey, it makes it looks like files discovered in my workspace? Maybe just having the quick pick be the description would help? Not a blocker, but certainly made me stop and scratch my head.

@jrieken
Copy link
Member Author

jrieken commented Aug 27, 2021

Maybe its because the file pattern is bold

Yeah, I didn't understand if those presented patterns are all patterns that can be used. Or is this a list of commonly used patterns and hides the complexity of real glob patterns

@roblourens
Copy link
Member

I might have been a little confused by the flow if we didn't just go through it in detail this morning 😁. From #21845

additionally the button "configure tests" found on the test explorer would be changed so it routed the user to a menu of the launch config options for testing

So in the new proposal, you wouldn't guide the user through picking the test folder/pattern? How do they know to configure that?

I don't necessarily mind the quick pick options as they currently are, it's probably nicer than asking the user to type a glob pattern. I assume the suggested patterns are typical for python projects. I just have a couple suggestions

  • After I go through this flow, open the config file to the side so I can see what you added, and see that I can customize it
  • Or show a notification with a button to open the file- we do this for some other flows that generate configuration for the user, like adding an ssh host automatically

@eleanorjboyd eleanorjboyd self-assigned this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing feature-request Request for new features or functionality needs proposal Need to make some design decisions partner ask
Projects
None yet
Development

No branches or pull requests

6 participants