Skip to content

Prototype whole notebook LSP messages #18467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
karthiknadig opened this issue Feb 7, 2022 · 1 comment
Closed

Prototype whole notebook LSP messages #18467

karthiknadig opened this issue Feb 7, 2022 · 1 comment
Assignees
@karthiknadig
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality needs spike Label for issues that need investigation before they can be worked on. verified Verification succeeded
Milestone
February 2022

Comments

@karthiknadig
Copy link
Member

No description provided.

@karthiknadig karthiknadig added feature-request Request for new features or functionality area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs spike Label for issues that need investigation before they can be worked on. labels Feb 7, 2022
@karthiknadig karthiknadig added this to the February 2022 milestone Feb 7, 2022
@karthiknadig karthiknadig self-assigned this Feb 7, 2022
@kieferrm kieferrm mentioned this issue Feb 16, 2022
Closed
28 tasks
@karthiknadig
Copy link
Member Author

We were able to implement the full notebook sync mode. There are a few items that we need to think about when it comes to analyzing notebooks as a whole.

When analyzing the notebook using a merged document means that the static analysis tool could find problems that only exist in the merged document but not in the parts. The other thing is the parts may not be analyzable on their own. But those problems are not real problems for the notebook, but just artefact of putting them together in a merged document for analysis.

@karthiknadig karthiknadig added the verified Verification succeeded label Feb 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karthiknadig karthiknadig

Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality needs spike Label for issues that need investigation before they can be worked on. verified Verification succeeded
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
1 participant
@karthiknadig