Skip to content

"Create environment" error message isn't helpful #20297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roblourens opened this issue Nov 30, 2022 · 4 comments
Closed

"Create environment" error message isn't helpful #20297

roblourens opened this issue Nov 30, 2022 · 4 comments
Labels
feature-request Request for new features or functionality

Comments

@roblourens
Copy link
Member

roblourens commented Nov 30, 2022

Testing microsoft/vscode-jupyter#11963

image

I just ran "Create environment" with the global python iterpreter, I can't remember how I set it up but I suppose it doesn't have pip available. Also there should not be 2 error messages

@roblourens roblourens added the feature-request Request for new features or functionality label Nov 30, 2022
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 30, 2022
@karthiknadig
Copy link
Member

We added modal error for some cases. @luabud Should we switch to error notification only in all cases?

@karthiknadig karthiknadig added needs proposal Need to make some design decisions and removed triage-needed Needs assignment to the proper sub-team labels Jan 5, 2023
@karthiknadig karthiknadig removed their assignment Jan 5, 2023
@luabud
Copy link
Member

luabud commented Jan 6, 2023

Yeah I think that's a good idea. It's not a blocking error (in a sense that if you end up choosing a different environment you can keep going), so I vote for using error notifications in all cases. @cwebster-99 -- what do you think?

@cwebster-99
Copy link
Member

I think switching to only showing error notifications makes sense for this scenario and reduces "clutter" on the screen. Are we able to add more information to the error notification (i.e. add information from the modal notification to the error notification) so it is more actionable for the user without them having to show output?

@luabud
Copy link
Member

luabud commented Sep 8, 2023

I believe #21896 fixed this. Errors are now reported only through a notification, where you can either check the output or select a different interpreter:

image

@luabud luabud closed this as completed Sep 8, 2023
@github-actions github-actions bot removed the needs proposal Need to make some design decisions label Sep 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants