Skip to content

Add separate python.testing.pytestArgs setting for test discovery and run #21190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mpekurin opened this issue May 5, 2023 · 1 comment
Closed
Labels
feature-request Request for new features or functionality needs community feedback Awaiting community feedback

Comments

@mpekurin
Copy link

mpekurin commented May 5, 2023

Each time the test discovery is executed (either via the Refresh Tests button or automatically) the extension runs run_adapter.py discover pytest ... with all the arguments listed in python.testing.pytestArgs passed in. While such behavior (maybe) makes sense, it would be nice to have an option to ignore the arguments or set the ones used for discovery in a separate parameter (like python.testing.pytestDiscoveryArgs).

This change would help to avoid implicit / unwanted actions on a discovery run, e.g. overwriting a coverage report file.

@mpekurin mpekurin added the feature-request Request for new features or functionality label May 5, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label May 5, 2023
@karthiknadig karthiknadig added needs community feedback Awaiting community feedback and removed triage-needed Needs assignment to the proper sub-team labels May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

@karthiknadig karthiknadig changed the title Add a way to ignore python.testing.pytestArgs for test discovery Add separate python.testing.pytestArgs setting for test discovery and run May 9, 2023
@mpekurin mpekurin closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality needs community feedback Awaiting community feedback
Projects
None yet
Development

No branches or pull requests

2 participants