-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Is "create environment" the right action on a missing dependency #21334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I had a similar thought process as I have been digging into our package management story. Providing an option to sync the dependency file with the selected environment is a typical user scenario and one that would improve our story here. We could provide an option to sync/update the environment and then Create Environment as a secondary option or based on specific scenario filtering. |
There are a few things to consider here. We should not be updating a global environment, that can pretty much break everything on a user's system.
|
The "Update environment" would also be useful when, for example, pyproject.toml has an error. I formatted project dependencies as object, not list.. and got an error. But there doesn't really seem to be a way to cleanly re-run the "create environment" command. |
Hey @karthiknadig @cwebster-99, this issue might need further attention. @connor4312, you can help us out by closing this issue if the problem no longer exists, or adding more information. |
Testing #21289
It seems strange that adding a new dependency to the requirements.txt makes the "Create Environment" button if I already have an environment. If a new dependency comes in, I assume the most common action would to "Update [the] Environment" to include the new package. Maybe that opens a confirmation quickpick where they have an option to create a new environment instead.
The text was updated successfully, but these errors were encountered: