Skip to content

Localization bugs in Python walkthrough #22419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joyceerhl opened this issue Nov 3, 2023 · 1 comment · Fixed by #22432
Closed

Localization bugs in Python walkthrough #22419

joyceerhl opened this issue Nov 3, 2023 · 1 comment · Fixed by #22432
Assignees
@luabud @cwebster-99
Labels
triage-needed Needs assignment to the proper sub-team

Comments

@joyceerhl
Copy link

This is with display language configured to French

image

You probably need your package.nls.json to specify a Locked comment for the string. Example: https://github.com/microsoft/vscode/blob/b74c660b2f7ee3d97039b1f50406d6c259b13fdb/extensions/git/package.nls.json#L371-L377
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 3, 2023
@cwebster-99 cwebster-99 linked a pull request Nov 8, 2023 that will close this issue
Adding Locked comments to walkthrough commands #22432
Merged
@cwebster-99
Copy link
Member

Thanks for calling this out. I have added Locked comments for the command names that should address this issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luabud luabud

@cwebster-99 cwebster-99

Labels
triage-needed Needs assignment to the proper sub-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding Locked comments to walkthrough commands microsoft/vscode-python
3 participants
@joyceerhl @luabud @cwebster-99