-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Decide whether we want to support third-party library snippets #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I see valid arguments either way, from a user perspective having some sort of "batteries included" extension that I can add that includes snippets for many common python tools/libs would be useful. Whether that lives here or in an additional "third-party python tools" extension I really don't care. From a "marketing" standpoint, having some of these commonly used tool snippets makes for a better out of the box experience for VS Code n00bs... I actually contributed the As I'm sure you're aware, the problem is that this path leads to subjective judgement calls on which tools are "popular enough" to include. You also might think about splitting the python snippets file into two... one for basic python, and one for python-common-third-party-extensions. I would enable them both, it just makes maintenance easier if it's split into two files. |
@qubitron @Microsoft/pvsc-team any thoughts on this so we don't leave @jeffwidman hanging too long with his PR? I'll start off by saying I'm willing to accept PRs for snippets and such involving popular projects, but it's up to our subjective choice as to what is "popular" and we obviously reserve the right to yank support as deemed necessary (e.g. popularity drops, support becomes painful, etc.). |
After discussing things over with @qubitron , we decided we will accept snippets for third-party projects and just use our own common-sense on when we think the usefulness of a snippet is simply too marginal to warrant the overhead of having the snippet name show up in the UI. |
That sounds reasonable to me. I'd also continue to work hard to make sure the 3p snippets are in separate code from the stdlib snippets... just makes life easier. |
#370 brings up the point as to where we draw the line for having snippets for third-party libraries (especially for ones that the extension isn't explicitly set up to support). E.g. should we drop the
ipdb
snippet and stick to only stuff that works with the stdlib or if we specifically support it somehow in the extension (e.g. someflake8
snippet)?The text was updated successfully, but these errors were encountered: