Skip to content

Modify PythonSettings.getInstance to default to current workspace #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DonJayamanne opened this issue Dec 22, 2017 · 1 comment
Closed
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone

Comments

@DonJayamanne
Copy link

If nothing is passed into getInstance method as the value for the resource arguement, then use the current workspace as the default.

  • This prevents VS Code from printing warnings such as the following:

[ms-python.python] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for 'python.xxx', provide the URI of a resource or 'null' for any resource.

@DonJayamanne DonJayamanne added awaiting 2-PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Dec 22, 2017
@brettcannon brettcannon changed the title Modify PythonSettings.getIstance to default to current workspace Modify PythonSettings.getInstance to default to current workspace Jan 2, 2018
@DonJayamanne
Copy link
Author

Closing as this is how the extension works today.
The problem was in the Unit test (Configuration Settings: Check Values) which has been resolve since.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

3 participants