enabling ctrl+enter to execute current line in .py script and moving cursor to next line

[myusrn]

Environment data

VS Code version: 1.19.1
Python Extension version: 0.9.1
Python Version: 3.6.2 anaconda
OS and version: win10 version 1709 (build 17025.1000)

Actual behavior

ctrl+enter does nothing

Expected behavior

ctrl+enter executes "Run Selection/Line in Python Terminal" [ / python.execSelectionInTerminal ] context menu option and indexes cursor in editor to next line, i.e. like behavior with vscode R extension environment and with vs17 ide python script support.

Steps to reproduce:

• open .py file in vscode
• place cursor on a line of script
• enter "ctrl+enter"

Logs

Output from Python output panel

Output from Console window (Help->Developer Tools menu)

[myusrn]

I reviewed what the R 0.5.2 extension by Yuki Ueda adds to default keybindings as part of its install to enable this
{ "key": "ctrl+enter", "command": "r.runSelection", "when": "editorTextFocus && editorLangId == 'r'" }

I then opened the %appdata%\Code\User\keybindings.json user customized keyboard settings file and added this entry
{ "key": "ctrl+enter", "command": "python.execSelectionInTerminal", "when": "editorTextFocus && editorLangId == 'python'" }

After which when i have a .py file open in vscode and use keyboard shortcut ctrl+enter it successfully executes the msft python extension's "Run Selection/Line in Python Terminal" [ / python.execSelectionInTerminal ] command. The other problem with this python extension command currently is whether you execute it from the command pallet or context menu after execution it doesn't index cursor to next line in script editor but rather leaves you with cursor on the python terminal command prompt.

So my ask would be to setup this keyboard shortcut setting in the default Keybindings settings as part of the extension install so we have parity with how R works and how this is supported in vs17 ide python. Also change the "Run Selection/Line in Python Terminal" [ / python.execSelectionInTerminal ] command such that it leaves cursor on next line in script editor and not on python terminal command prompt.

[DonJayamanne]

Keeping focus on editor is duplicate of microsoft/vscode-python#60.

[myusrn]

Hey folks, I see the duplicate microsoft/vscode-python#60 item as closed in January 2018 but haven't seen update to extension that addresses executing line and moving cursor to next line in source file. Likewise no default setup by extension of a ctrl+enter keybindings that wires up "when": "editorTextFocus && editorLangId == 'python'" to "command": "python.execSelectionInTerminal" and "cursorDown".

Was the closure of microsoft/vscode-python#60 based on the assumption that users would manually add settings to do these actions on ctrl+enter as shown below?

settings.json

"macros": {  // update: requires macros extension by publisher:"geddski" 
        "pythonExecSelectionAndCursorDown": [
            "python.execSelectionInTerminal", 
            //"vscode.window.activeTextEditor.show()",
            "cursorDown" 
        ]
    },

keybindings.json

{
        "key": "ctrl+enter",
        //"command": [ "python.execSelectionInTerminal", "cursorDown" ],
        "command": "macros.pythonExecSelectionAndCursorDown",
        "when": "editorTextFocus && editorLangId == 'python'"
    }

note - as part of trying to get crtl+enter keybindings.json entry to execute the multiple commands needed when it was used I tried the macros option I had seen mentioned in other articles but it produced a warning stating "command 'macros.pythonExecSelectionAndCursorDown' not found." [ update: as highlighted in latter issue comments this warning was because I did not have required macros extension by publisher:"geddski" installed ]

[yelled1]

I have a similar issue but little diff
"macros": {
"execCurLnPy": [
"expandLineSelection",
"python.execSelectionInTerminal",
"cancelSelection"
],
"execCurSelPy": [
"Enter",
"python.execSelectionInTerminal",
"cancelSelection",
],
},

execCurLnPy works well just goes down to next line & I can just keep on hitting C-Enter
for above problem this may solve it, as u can be anywhere on the line & it automatically adv to next line.

My problem is with
execCurSelPy
fileDict = {}

soupDict = {}
for f in htmlFiles:
... with open(f) as fp:
... lns = fp.read()
... js = HTMLtoJSONParser.to_json(lns)
... soup = BeautifulSoup(lns, "html.parser")
... fileDict[f] = js
... soupDict[f] = soup
...
And just hangs unless either I select in next blank line when I send it
or I go down to terminal & hit the Enter myself.
Either is a bit of pain:
is there anyway I can attach an Enter/line feed to selection automatically from macros?
Or send a Enter/line after python.execSelectionInTerminal?:
something like python.execInTerminal(line feed)

I am unlikely to push half of loop into the terminal. So, this is desired & mimics Emacs elpy.
Thanks,

[myusrn]

@yelled1

The "cursorDown" command will do a crlf in editor for you. I've tested linking just that command to ctrl+enter and it does what its expected to.

My blocking issue is getting two commands to execute when I use ctrl+enter keyboard shortcut. It sounds like your keybindings.json reference/use of a settings.json defined macros setting with multiple commands defined, e.g. command: "macros.execCurLnPy" and command: "macro.execCurSelPy", is successfully being executed when you use associated ctrl+enter keyboard shortcut. If so did you do something different than I did setting that up that macros definition to make it visible to the keybindings.json keyboard shortcut settings?

I ask because as noted in my earlier post i'm getting the error "command 'macros.<macro defined in settings.json>' not found." result.

If that piece was working I believe i'd have my interim workaround that facilitated the same ctrl+enter behavior as vs17 python editor experience provides.

I raised a question about why this isn't multiple commands macros associated keyboard shortcut setting isn't working for me in this SO post but have gotten no responses with solutions to it.

[yelled1]

Ok, let me c if I can hlp w/ that.

1. see if u have macros 1.2.1 installed & enabled (dumb but always ck simple)

2. settings.json should have
   {
   "window.zoomLevel": 1, //-1 makes small
   "editor.fontSize": 11,
   "terminal.integrated.fontSize": 11,

   "macros": {
   "execCurLnPy": [
   "expandLineSelection",
   "python.execSelectionInTerminal",
   "cancelSelection"
   ],
   "execCurSelPy": [
   "cursorDown",
   "python.execSelectionInTerminal",
   "cancelSelection",
   ],
   "execCurLn": [
   "expandLineSelection",
   "workbench.action.terminal.runSelectedText",
   "cancelSelection"
   ],
   "execCurSel": [
   "workbench.action.terminal.runSelectedText",
   "cancelSelection",
   ],
   },
   "julia.executablePath": "/opt/julia/bin/julia",
   "python.pythonPath": "/opt/miniconda3/envs/SPk/bin/python"
   }

3. keybinding.json
   {"key": "ctrl+enter",
   "command": "-editor.action.insertLineAfter",
   "when": "editorTextFocus && !editorReadonly"

   { "key": "ctrl+enter", "command": "macros.execCurSelPy", "when": "editorTextFocus && editorHasSelection && editorLangId == 'python'" },
   { "key": "ctrl+enter", "command": "macros.execCurLnPy", "when": "editorTextFocus && !editorHasSelection && editorLangId == 'python'" },

   { "key": "ctrl+enter", "command": "macros.execCurSel", "when": "editorTextFocus && editorHasSelection && editorLangId != 'python'" },
   { "key": "ctrl+enter", "command": "macros.execCurLn", "when": "editorTextFocus && !editorHasSelection && editorLangId != 'python'" },

   }
   Line "command": "-editor.action.insertLineAfter", might be important as it takes out the default behavior.
   Your cursorDown seems to NOT quite work. Let me know if you figure it out.
   So, I am just currently placing an empty line after each loops / with etc...
   Not clean but works. Let me know if u find a workaround.
   Thanks,

[myusrn]

Hi @yelled1
It was item 1) from your comment. The article I had originally found outlining use macros didn't comment on needing the "macros" extension by publisher:"geddski" installed for it to work. I added it and now things using the simple two commands I outlined in my earlier comment are providing the desired result, thanks.

[brettcannon]

We will look at adding this after microsoft/vscode-python#1349 lands.

[kraigb]

Yes, Ctrl+Enter should move to the next line, which makes it consistent with the behavior in PTVS. The auto-move to the next line makes Ctrl+Enter a super-useful tool to step through code. Without it, the utility is much more limited.

[numpynewb]

@myusrn thank you for your macro and keybinding code. This works very nicely for me! @brettcannon, will this be integrated into VSCode, now that microsoft/vscode-python#1349 was merged?

This has been a very nice add for me personally, but feel that it has broad appeal. Avoiding the extra steps needed to install the additional extension and manually add the shortcut would be great. Loving VSCode, and seemingly small improvements like this keep me from swapping into other dev. envs. (like Jupyter Notebook, for example, when running local exploratory analysis in Python).

Cheers,

[brettcannon]

@numpynewb we haven't explicitly looked into it yet as other high-priority stuff has been cropping up as of late.

[cui-colin]

I can give it a try, can someone tell me where the json file is located? Thanks!