Skip to content

startup time approximately 2 seconds #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gurkanctn opened this issue Jan 26, 2018 · 6 comments
Closed

startup time approximately 2 seconds #639

gurkanctn opened this issue Jan 26, 2018 · 6 comments
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@gurkanctn
Copy link

  • Extension Name: python
  • Extension Version: 0.9.1
  • OS Version: Windows_NT x64 10.0.16299
  • VSCode version: 1.19.3

We have written the needed data into your clipboard. Please paste:

{
	"activationTimes": {
		"startup": false,
		"codeLoadingTime": 1545,
		"activateCallTime": 162,
		"activateResolvedTime": 44,
		"activationEvent": "onLanguage:python"
	}
}
@DonJayamanne DonJayamanne added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. feature-extension labels Jan 29, 2018
@DonJayamanne
Copy link

@gurkanctn
Currently when the extension loads, it tries to locate interpreters on your current system (one time operation), this list is then used to allow users to change the interpreter for the workspace.
I believe this is where the majority of the delay is.

Would you be kind enough to explain how this currently effects your current workflow.
How did you experience this delay when using the extension before looking at the activation times.

@DonJayamanne
Copy link

Added awaiting 2-PR as we can make some minor improvements to the performance.

@brettcannon brettcannon changed the title startup time approximately 2 seconds? (too long!) startup time approximately 2 seconds Jan 29, 2018
@MikhailArkhipov
Copy link

So it is codeLoadingTime that takes the most.

@DonJayamanne
Copy link

DonJayamanne commented Mar 17, 2018

Closing this issue as we've improved the performance to bring it down to under 500ms.
Changes should be available in the current release of the extension.

How to test:

  • Open a workspace with python files
  • Open a python file (to activate the python extension)
  • Go into the command palette and select Developer: Startup Performance
  • A table will be rendered in the console window

Closed via #953 and #931. Further performance improvements will be tracked under #951

@gurkanctn
Copy link
Author

@DonJayamanne , thanks a lot for the improvement.

At the table you mentioned, my duration adds up to 80. But I don't know the unit of it. I didn't measure myself but it definitely is not 80 msecs. Still, I felt an improvement at startup with the February version (that I upgraded right now).

@DonJayamanne
Copy link

The values in the table are provided by vscode, not the extension.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

4 participants