Skip to content

FIleSystem tests in Single Workspace Tests fail locally on a Mac #8968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DonJayamanne opened this issue Dec 9, 2019 · 1 comment
Closed

FIleSystem tests in Single Workspace Tests fail locally on a Mac #8968

DonJayamanne opened this issue Dec 9, 2019 · 1 comment
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@DonJayamanne
Copy link

Running single workspace tests fail on a local Mac OS, for FS tests.
Not sure where the problem is, incomplete test or flaky test.

Tests seem to be written to such that ctime value will bve 0, but the code doesn't return 0, hence tests fail.

Screen Shot 2019-12-09 at 11 45 31

Screen Shot 2019-12-09 at 11 43 36
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels Dec 9, 2019
@DonJayamanne DonJayamanne changed the title Running Single Workspace Tests fail when they shouldn't FIleSystem tests in Single Workspace Tests fail locally on a Mac Dec 9, 2019
@karthiknadig
Copy link
Member

The FS changes are being reverted see #8970

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Dec 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DonJayamanne @karthiknadig