Skip to content

Multiroot test failure (tests do not even start running) #9361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DonJayamanne opened this issue Jan 2, 2020 · 3 comments
Closed

Multiroot test failure (tests do not even start running) #9361

DonJayamanne opened this issue Jan 2, 2020 · 3 comments
Labels
bug Issue identified by VS Code Team member as probable bug regression Bug didn't exist in a previous release

Comments

@DonJayamanne
Copy link

Looks like some of the multi-root tests are failing fairly consistently due to some recent change.
I can see that it used to work up until 2-3 days ago.
The tests just don't run.
This isn't the same as #9360

Screen Shot 2020-01-02 at 10 43 13

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team P0 labels Jan 2, 2020
@karrtikr
Copy link

karrtikr commented Jan 2, 2020

They have been failing fairly consistently since months, it's just that when #9329 got fixed, these failures became visible. These should be fixed with PR #9351 which is just waiting on your review.

@DonJayamanne
Copy link
Author

DonJayamanne commented Jan 2, 2020

ey have been failing fairly consistently since months, it's just that when

Not convinced about that, though I could be completely wrong. As when activation fails within the allocated time, then an error is logged. However I don't see any errors logged in this job.

@karrtikr karrtikr added needs PR regression Bug didn't exist in a previous release and removed triage-needed Needs assignment to the proper sub-team labels Jan 2, 2020
@karrtikr karrtikr added this to the 2019 December Sprint 1 milestone Jan 2, 2020
@kimadeline
Copy link

✅ Doesn't seem to be happening anymore: the tests run, they are back to timing out every so often (see the 3 attempts on https://dev.azure.com/ms/vscode-python/_build/results?buildId=57872&view=results)

@ghost ghost removed the needs PR label Jan 10, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug regression Bug didn't exist in a previous release
Projects
None yet
Development

No branches or pull requests

3 participants