Skip to content

Turning off word-based suggestions isn't enough for comments #22601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emackey opened this issue Mar 14, 2017 · 3 comments
Closed

Turning off word-based suggestions isn't enough for comments #22601

emackey opened this issue Mar 14, 2017 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) suggest IntelliSense, Auto Complete
Milestone

Comments

@emackey
Copy link

emackey commented Mar 14, 2017

I set editor.wordBasedSuggestions: false in my user-level settings, and even restarted vscode, but if I open a *.js JavaScript file and type the following:

    // If

Still, vscode pops up some kind of suggestions about the JavaScript keyword if, even though I'm trying to write simple English in my comment. Is there any way to really, fully disable all suggestions for comments?

(Originally posted in an unrelated issue, #17426)

@jrieken jrieken added feature-request Request for new features or functionality suggest IntelliSense, Auto Complete labels Mar 14, 2017
@emackey
Copy link
Author

emackey commented Mar 15, 2017

The problem is coming from code snippet suggestions being used inside comments. For example, type the following and press ENTER:

// Fred's

When ENTER is pressed, VSCode inserts the following text:

// Fred'setTimeout(function() {
    
}, timeout);

@jrieken jrieken added this to the March 2017 milestone Mar 15, 2017
@jrieken
Copy link
Member

jrieken commented Mar 15, 2017

Yes - we will have to revisit this. We have now an action that controls word-base suggestions but that's not so useful... The new idea is to control is quick suggestion should kick off when inside comments or strings. So, when explicitly requested suggestion (including words, snippets) will still come but not as you type (24x7-IntelliSense)

@jrieken
Copy link
Member

jrieken commented Mar 17, 2017

We have fixed that in the original issue. Quick suggestion aka 24x7 suggestions are not disabled by default when typing in comments or strings and must be enabled explicitly. See #9504

@jrieken jrieken closed this as completed Mar 17, 2017
@jrieken jrieken added *duplicate Issue identified as a duplicate of another issue(s) and removed feature-request Request for new features or functionality labels Mar 17, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) suggest IntelliSense, Auto Complete
Projects
None yet
Development

No branches or pull requests

2 participants