Skip to content

Support comments in UI editors (settings and keyboard shortcuts) #68184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jabacchetta opened this issue Feb 8, 2019 · 0 comments
Open

Support comments in UI editors (settings and keyboard shortcuts) #68184

jabacchetta opened this issue Feb 8, 2019 · 0 comments
Assignees
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues
Milestone

Comments

@jabacchetta
Copy link

jabacchetta commented Feb 8, 2019

I prefer using the UI editor for both settings and keyboard shortcuts. However, I often find myself automatically going into the JSON files because they're packed with comments — for both modified and unmodified settings/keyboard rules (example shown below).

Feature Request

  • Support ability to add comments to the UI editors, possibly with an icon next to the setting/keyboard rule (if it has a comment), allowing the comment to be viewed by hovering over the icon.
  • Add additional tags that would allow you to further filter the results (e.g. @commented, @modified @commented, @unmodified @commented).

Note

This would also solve a bug where comments in the JSON file are removed (without any indication) when making changes in the UI editor. See #75599.

Example

Here's an example settings.json file that has comments for both modified and unmodified settings:

{
  // Disabling validation prevents errors on syntax constructs that aren't supported by the language
  // service (e.g. proposed features such as the pipeline operator). It also prevents duplicate
  // linting errors (from both ts and eslint). However, it also prevents the editor.showUnused
  // (fading of unused variables) option from working.
  // https://github.com/Microsoft/TypeScript/issues/29293)
  // https://github.com/Microsoft/TypeScript/issues/13408
  "javascript.validate.enable": false,
  "typescript.validate.enable": false,

  // Good for disabling annoying tooltips, but nice for eslint error details.
  // Waiting for ability to customize tooltips or place the tooltips at top/bottom.
  // https://github.com/Microsoft/vscode/issues/65996
  // "editor.hover.enabled": false,
}
@roblourens roblourens added feature-request Request for new features or functionality settings-editor VS Code settings editor issues labels Feb 11, 2019
@jabacchetta jabacchetta changed the title Custom comments in Settings UI Support comments in UI editors (settings and keyboard shortcuts) Sep 10, 2019
@roblourens roblourens added this to the Backlog milestone Oct 28, 2019
@rzhao271 rzhao271 assigned rzhao271 and unassigned roblourens Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues
Projects
None yet
Development

No branches or pull requests

3 participants