Skip to content

Update default value for terminal.integrated.inheritEnv #75377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tyriar opened this issue Jun 12, 2019 · 5 comments
Closed

Update default value for terminal.integrated.inheritEnv #75377

Tyriar opened this issue Jun 12, 2019 · 5 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label
Milestone
On Deck

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 12, 2019

Introduced in #70248, we should switch the default to isWindows (or false) after warning users in the release notes, provided it all works as expected. In July or August probably?
@Tyriar Tyriar added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label labels Jun 12, 2019
@Tyriar Tyriar added this to the July 2019 milestone Jun 12, 2019
@Tyriar Tyriar self-assigned this Jun 12, 2019
@DonJayamanne
Copy link
Contributor

Will test at my end and get back to you.

@DonJayamanne DonJayamanne mentioned this issue Jun 13, 2019
Closed
@DonJayamanne
Copy link
Contributor

Tested at my end and works as expected.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 13, 2019

@DonJayamanne cool, let me know if any Python users have problems with it

@Tyriar
Copy link
Member Author

Tyriar commented Jun 28, 2019

Maybe the default should be !!remoteAuthority since false in remote now means it will pull the server's env, not the ext host's.

@Tyriar Tyriar modified the milestones: July 2019, On Deck Jul 11, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Oct 9, 2019

Not changing for now, there are some issues with it.

@Tyriar Tyriar closed this as completed Oct 9, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
2 participants
@DonJayamanne @Tyriar