Bump Luau to 0.674

Author: khvzak

luau/Ast/include/Luau/Cst.h

@@ -116,7 +116,9 @@ class CstExprFunction : public CstNode
     Position openGenericsPosition{0, 0};
     AstArray<Position> genericsCommaPositions;
     Position closeGenericsPosition{0, 0};
+    AstArray<Position> argsAnnotationColonPositions;
     AstArray<Position> argsCommaPositions;
+    Position varargAnnotationColonPosition{0, 0};
     Position returnSpecifierPosition{0, 0};
 };
 
@@ -224,8 +226,9 @@ class CstStatLocal : public CstNode
 public:
     LUAU_CST_RTTI(CstStatLocal)
 
-    CstStatLocal(AstArray<Position> varsCommaPositions, AstArray<Position> valuesCommaPositions);
+    CstStatLocal(AstArray<Position> varsAnnotationColonPositions, AstArray<Position> varsCommaPositions, AstArray<Position> valuesCommaPositions);
 
+    AstArray<Position> varsAnnotationColonPositions;
     AstArray<Position> varsCommaPositions;
     AstArray<Position> valuesCommaPositions;
 };
@@ -235,8 +238,9 @@ class CstStatFor : public CstNode
 public:
     LUAU_CST_RTTI(CstStatFor)
 
-    CstStatFor(Position equalsPosition, Position endCommaPosition, std::optional<Position> stepCommaPosition);
+    CstStatFor(Position annotationColonPosition, Position equalsPosition, Position endCommaPosition, std::optional<Position> stepCommaPosition);
 
+    Position annotationColonPosition;
     Position equalsPosition;
     Position endCommaPosition;
     std::optional<Position> stepCommaPosition;
@@ -247,8 +251,9 @@ class CstStatForIn : public CstNode
 public:
     LUAU_CST_RTTI(CstStatForIn)
 
-    CstStatForIn(AstArray<Position> varsCommaPositions, AstArray<Position> valuesCommaPositions);
+    CstStatForIn(AstArray<Position> varsAnnotationColonPositions, AstArray<Position> varsCommaPositions, AstArray<Position> valuesCommaPositions);
 
+    AstArray<Position> varsAnnotationColonPositions;
     AstArray<Position> varsCommaPositions;
     AstArray<Position> valuesCommaPositions;
 };

luau/Ast/include/Luau/ParseResult.h

@@ -84,6 +84,6 @@ struct ParseExprResult
     CstNodeMap cstNodeMap{nullptr};
 };
 
-static constexpr const char* kParseNameError = "%error-id%";
+inline constexpr const char* kParseNameError = "%error-id%";
 
 } // namespace Luau

luau/Ast/include/Luau/Parser.h

@@ -196,14 +196,16 @@ class Parser
 
     // binding ::= Name [`:` Type]
     Binding parseBinding();
+    AstArray<Position> extractAnnotationColonPositions(const TempVector<Binding>& bindings);
 
     // bindinglist ::= (binding | `...') {`,' bindinglist}
     // Returns the location of the vararg ..., or std::nullopt if the function is not vararg.
     std::tuple<bool, Location, AstTypePack*> parseBindingList(
         TempVector<Binding>& result,
         bool allowDot3 = false,
         AstArray<Position>* commaPositions = nullptr,
-        std::optional<Position> initialCommaPosition = std::nullopt
+        Position* initialCommaPosition = nullptr,
+        Position* varargAnnotationColonPosition = nullptr
     );
 
     AstType* parseOptionalType();
@@ -243,8 +245,6 @@ class Parser
     };
 
     TableIndexerResult parseTableIndexer(AstTableAccess access, std::optional<Location> accessLocation, Lexeme begin);
-    // Remove with FFlagLuauStoreCSTData2
-    AstTableIndexer* parseTableIndexer_DEPRECATED(AstTableAccess access, std::optional<Location> accessLocation, Lexeme begin);
 
     AstTypeOrPack parseFunctionType(bool allowPack, const AstArray<AstAttr*>& attributes);
     AstType* parseFunctionTypeTail(
@@ -452,10 +452,12 @@ class Parser
     {
         Name name;
         AstType* annotation;
+        Position colonPosition;
 
-        explicit Binding(const Name& name, AstType* annotation = nullptr)
+        explicit Binding(const Name& name, AstType* annotation = nullptr, Position colonPosition = {0,0})
             : name(name)
             , annotation(annotation)
+            , colonPosition(colonPosition)
         {
         }
     };

luau/Ast/src/Ast.cpp

@@ -3,16 +3,13 @@
 
 #include "Luau/Common.h"
 
-LUAU_FASTFLAG(LuauDeprecatedAttribute);
 LUAU_FASTFLAG(LuauStoreReturnTypesAsPackOnAst)
 
 namespace Luau
 {
 
 static bool hasAttributeInArray(const AstArray<AstAttr*> attributes, AstAttr::Type attributeType)
 {
-    LUAU_ASSERT(FFlag::LuauDeprecatedAttribute);
-
     for (const auto attribute : attributes)
     {
         if (attribute->type == attributeType)
@@ -338,8 +335,6 @@ bool AstExprFunction::hasNativeAttribute() const
 
 bool AstExprFunction::hasAttribute(const AstAttr::Type attributeType) const
 {
-    LUAU_ASSERT(FFlag::LuauDeprecatedAttribute);
-
     return hasAttributeInArray(attributes, attributeType);
 }
 
@@ -1026,8 +1021,6 @@ bool AstStatDeclareFunction::isCheckedFunction() const
 
 bool AstStatDeclareFunction::hasAttribute(AstAttr::Type attributeType) const
 {
-    LUAU_ASSERT(FFlag::LuauDeprecatedAttribute);
-
     return hasAttributeInArray(attributes, attributeType);
 }
 
@@ -1244,8 +1237,6 @@ bool AstTypeFunction::isCheckedFunction() const
 
 bool AstTypeFunction::hasAttribute(AstAttr::Type attributeType) const
 {
-    LUAU_ASSERT(FFlag::LuauDeprecatedAttribute);
-
     return hasAttributeInArray(attributes, attributeType);
 }
 

luau/Ast/src/Cst.cpp

@@ -94,23 +94,26 @@ CstStatReturn::CstStatReturn(AstArray<Position> commaPositions)
 {
 }
 
-CstStatLocal::CstStatLocal(AstArray<Position> varsCommaPositions, AstArray<Position> valuesCommaPositions)
+CstStatLocal::CstStatLocal(AstArray<Position> varsAnnotationColonPositions, AstArray<Position> varsCommaPositions, AstArray<Position> valuesCommaPositions)
     : CstNode(CstClassIndex())
+    , varsAnnotationColonPositions(varsAnnotationColonPositions)
     , varsCommaPositions(varsCommaPositions)
     , valuesCommaPositions(valuesCommaPositions)
 {
 }
 
-CstStatFor::CstStatFor(Position equalsPosition, Position endCommaPosition, std::optional<Position> stepCommaPosition)
+CstStatFor::CstStatFor(Position annotationColonPosition, Position equalsPosition, Position endCommaPosition, std::optional<Position> stepCommaPosition)
     : CstNode(CstClassIndex())
+    , annotationColonPosition(annotationColonPosition)
     , equalsPosition(equalsPosition)
     , endCommaPosition(endCommaPosition)
     , stepCommaPosition(stepCommaPosition)
 {
 }
 
-CstStatForIn::CstStatForIn(AstArray<Position> varsCommaPositions, AstArray<Position> valuesCommaPositions)
+CstStatForIn::CstStatForIn(AstArray<Position> varsAnnotationColonPositions, AstArray<Position> varsCommaPositions, AstArray<Position> valuesCommaPositions)
     : CstNode(CstClassIndex())
+    , varsAnnotationColonPositions(varsAnnotationColonPositions)
     , varsCommaPositions(varsCommaPositions)
     , valuesCommaPositions(valuesCommaPositions)
 {