Skip to content

UnsubscribeResource_Stdio test is flaky #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stephentoub opened this issue Apr 7, 2025 · 0 comments · Fixed by #313
Closed

UnsubscribeResource_Stdio test is flaky #228

stephentoub opened this issue Apr 7, 2025 · 0 comments · Fixed by #313
Labels
test Issue related to tests

Comments

@stephentoub
Copy link
Contributor

It calls SubscribeToResourceAsync, validates a notification is received, then UnsubscribeFromResourceAsync, and tries to validate that no more notifications are received. But a notification could have been issued concurrently with UnsubscribeFromResourceAsync, in which case it could still arrive after the unsubscribe call.
@stephentoub stephentoub added the test Issue related to tests label Apr 7, 2025
This was referenced Apr 10, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issue related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete faulty assert stephentoub/mcp
1 participant
@stephentoub