Skip to content

Commit fd8797c

Browse files
committed
fix missing password field in knex (knex/knex@f6ea812)
1 parent 9b767db commit fd8797c

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

src/adapters/knex.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ class KnexAdapter extends BaseAdapter {
7979
*/
8080
async connect() {
8181
this.logger.debug(`Knex connecting...`);
82-
this.client = new Knex(this.opts.knex);
82+
// Should clone because Kney hides the password field
83+
this.client = new Knex(_.cloneDeep(this.opts.knex));
8384
}
8485

8586
/**

test/integration/tenants.test.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -760,14 +760,11 @@ module.exports = (getAdapter, adapterType) => {
760760

761761
if (adapterType == "Knex" && getAdapter.adapterName != "Knex-SQLite") {
762762
describe("Test schema-level tenancy", () => {
763-
const broker = new ServiceBroker({ logger: true });
763+
const broker = new ServiceBroker({ logger: false });
764764
const svc = broker.createService({
765765
mixins: [baseServiceSchema],
766766
methods: {
767767
getAdapterByContext(ctx, adapterDef) {
768-
// Somehow the password disappeared from the "adapterDef"
769-
adapterDef = getAdapter();
770-
771768
const tenantId = ctx.meta.tenantId;
772769
if (!tenantId) throw new Error("Missing tenantId!");
773770

0 commit comments

Comments
 (0)