PERL-667 Add and pass minimal Perl::Critic release tests

Author: xdg

Changes

@@ -2,6 +2,10 @@
 
 {{ $NEXT }}
 
+  [~ Internal changes ~]
+
+  - PERL-667 Add and pass Perl::Critic tests before release
+
 v1.5.0    2016-09-19 15:26:09-07:00 America/Los_Angeles (TRIAL RELEASE)
 
   [*** Deprecations ***]

dist.ini

@@ -63,7 +63,7 @@ max_target_perl = 5.008001
 ;also_private = qr/^[A-Z_]+$/
 
 ; check Perl::Critic
-;[Test::Perl::Critic]
+[Test::Perl::Critic]
 
 ;[Test::LocalBrew]
 ;brews         = perl-5.10.1

lib/MongoDB/BSON.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::BSON;
 
 

lib/MongoDB/BSON/Binary.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::BSON::Binary;
 # ABSTRACT: MongoDB binary type
 

lib/MongoDB/BSON/Regexp.pm

@@ -1,3 +1,5 @@
+use strict;
+use warnings;
 package MongoDB::BSON::Regexp;
 # ABSTRACT: Regular expression type
 

lib/MongoDB/BSON/_EncodedDoc.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::BSON::_EncodedDoc;
 
 # Wrapper for pre-encoded BSON documents, with optional metadata

lib/MongoDB/BulkWrite.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::BulkWrite;
 
 # ABSTRACT: MongoDB bulk write interface

lib/MongoDB/BulkWriteResult.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::BulkWriteResult;
 
 # ABSTRACT: MongoDB bulk write result document

lib/MongoDB/BulkWriteView.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::BulkWriteView;
 
 # ABSTRACT: Bulk write operations against a query document

lib/MongoDB/Code.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Code;
 
 

lib/MongoDB/Collection.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Collection;
 
 

lib/MongoDB/CommandResult.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::CommandResult;
 
 # ABSTRACT: MongoDB generic command result document

lib/MongoDB/Cursor.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Cursor;
 
 

lib/MongoDB/DBRef.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::DBRef;
 
 # ABSTRACT: A MongoDB database reference

lib/MongoDB/Database.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Database;
 
 

lib/MongoDB/DeleteResult.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::DeleteResult;
 
 # ABSTRACT: MongoDB deletion result object

lib/MongoDB/GridFS.pm

@@ -13,6 +13,8 @@
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
 
+use strict;
+use warnings;
 package MongoDB::GridFS;
 
 # ABSTRACT: A file storage abstraction (DEPRECATED)
@@ -245,7 +247,7 @@ sub find_one {
     $criteria ||= {};
 
     my $file = $self->files->find_one($criteria, $fields);
-    return undef unless $file;
+    return undef unless $file; ## no critic
     return MongoDB::GridFS::File->new({_grid => $self,info => $file});
 }
 

lib/MongoDB/GridFS/File.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::GridFS::File;
 
 

lib/MongoDB/GridFSBucket.pm

@@ -13,6 +13,8 @@
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
 
+use strict;
+use warnings;
 package MongoDB::GridFSBucket;
 
 # ABSTRACT: A file storage abstraction

lib/MongoDB/GridFSBucket/DownloadStream.pm

@@ -13,6 +13,8 @@
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
 
+use strict;
+use warnings;
 package MongoDB::GridFSBucket::DownloadStream;
 
 # ABSTRACT: File handle abstraction for downloading

lib/MongoDB/GridFSBucket/UploadStream.pm

@@ -13,6 +13,8 @@
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
 
+use strict;
+use warnings;
 package MongoDB::GridFSBucket::UploadStream;
 
 # ABSTRACT: File handle abstraction for uploading

lib/MongoDB/IndexView.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::IndexView;
 
 # ABSTRACT: Index management for a collection

lib/MongoDB/InsertManyResult.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::InsertManyResult;
 
 # ABSTRACT: MongoDB single insert result object

lib/MongoDB/InsertOneResult.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::InsertOneResult;
 
 # ABSTRACT: MongoDB single insert result object

lib/MongoDB/MongoClient.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::MongoClient;
 
 # ABSTRACT: A connection to a MongoDB server or multi-server deployment

lib/MongoDB/OID.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::OID;
 
 # ABSTRACT: A Mongo Object ID

lib/MongoDB/Op/_Aggregate.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_Aggregate;
 
 # Encapsulate aggregate operation; return MongoDB::QueryResult

lib/MongoDB/Op/_BatchInsert.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_BatchInsert;
 
 # Encapsulate a multi-document insert operation; returns a

lib/MongoDB/Op/_BulkWrite.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_BulkWrite;
 
 # Encapsulate a multi-document multi-operation write; returns a
@@ -380,7 +382,7 @@ sub _execute_legacy_batch {
                 return $_->result;
             }
             die $_ unless $w_0 && /exceeds maximum size/;
-            return undef;
+            return undef; ## no critic: this makes op_result undef
         };
 
         my $gle_result =

lib/MongoDB/Op/_Command.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_Command;
 
 # Encapsulate running a command and returning a MongoDB::CommandResult

lib/MongoDB/Op/_Count.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_Count;
 
 # Encapsulate code path for count commands

lib/MongoDB/Op/_CreateIndexes.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_CreateIndexes;
 
 # Encapsulate index creation operations; returns a MongoDB::CommandResult

lib/MongoDB/Op/_Delete.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_Delete;
 
 # Encapsulate a delete operation; returns a MongoDB::DeleteResult

lib/MongoDB/Op/_Distinct.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_Distinct;
 
 # Encapsulate distinct operation; return MongoDB::QueryResult

lib/MongoDB/Op/_DropCollection.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_DropCollection;
 
 # Implements a collection drop; returns a MongoDB::CommandResult

lib/MongoDB/Op/_DropDatabase.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_DropDatabase;
 
 # Implements a database drop; returns a MongoDB::CommandResult

lib/MongoDB/Op/_DropIndexes.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_DropIndexes;
 
 # Implements index drops; returns a MongoDB::CommandResult

lib/MongoDB/Op/_Explain.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_Explain;
 
 # Encapsulate code path for explain commands/queries

lib/MongoDB/Op/_FSyncUnlock.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_FSyncUnlock;
 
 # Encapsulate collection list operations; returns arrayref of collection

lib/MongoDB/Op/_FindAndDelete.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_FindAndDelete;
 
 # Encapsulate find_and_delete operation; atomically delete and return doc

lib/MongoDB/Op/_FindAndUpdate.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_FindAndUpdate;
 
 # Encapsulate find_and_update operation; atomically update and return doc

lib/MongoDB/Op/_GetMore.pm

@@ -14,6 +14,8 @@
 #  limitations under the License.
 #
 
+use strict;
+use warnings;
 package MongoDB::Op::_GetMore;
 
 # Encapsulate a cursor fetch operation; returns raw results object