Skip to content

Commit 2bad9c5

Browse files
committed
Fix: MongoClientSettings.applyConnectionString retryReads bug
Ensure that retryReads is copied. JAVA-5048
1 parent 1630676 commit 2bad9c5

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

driver-core/src/main/com/mongodb/MongoClientSettings.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,10 @@ public Builder applyConnectionString(final ConnectionString connectionString) {
299299
if (retryWritesValue != null) {
300300
retryWrites = retryWritesValue;
301301
}
302+
Boolean retryReadsValue = connectionString.getRetryReads();
303+
if (retryReadsValue != null) {
304+
retryReads = retryReadsValue;
305+
}
302306
if (connectionString.getUuidRepresentation() != null) {
303307
uuidRepresentation = connectionString.getUuidRepresentation();
304308
}

driver-core/src/test/unit/com/mongodb/MongoClientSettingsSpecification.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ class MongoClientSettingsSpecification extends Specification {
194194
.readPreference(ReadPreference.secondary())
195195
.writeConcern(WriteConcern.JOURNALED)
196196
.retryWrites(true)
197-
.retryReads(false)
197+
.retryReads(true)
198198
.readConcern(ReadConcern.LOCAL)
199199
.applicationName('app1')
200200
.addCommandListener(commandListener)

0 commit comments

Comments
 (0)